Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip plotting in TableReport when there are many columns #1245

Open
jeromedockes opened this issue Feb 24, 2025 · 3 comments
Open

Skip plotting in TableReport when there are many columns #1245

jeromedockes opened this issue Feb 24, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@jeromedockes
Copy link
Member

Problem Description

If the table has 100 columns, it takes a long time to generate the histograms and I probably won't look a them all anyway.
There could be a user-controllable threshold (say, 30 columns) above which no plots are generated and we get only the scrollable sample and summary statistics. Not sure if column associations should still be computed.

Feature Description

below the threshold, plots are generated for all columns.
above the threshold, no plots are generated.

skrub.TableReport(df, max_n_plots=30)

skrub.patch_display(max_n_plots=40)

None means always plot. (and 0 means never plot because there are always at least 0 columns)

Alternative Solutions

No response

Additional Context

No response

@jeromedockes jeromedockes added the enhancement New feature or request label Feb 24, 2025
@Vincent-Maladiere
Copy link
Member

If column associations are not a major compute-time bottleneck, I'd favor keeping them.

@jeromedockes
Copy link
Member Author

makes sense. I guess they will become the bottleneck once we remove the plotting, but they are very small compared to plotting. once we remove plotting we may not have any computation time problem anymore except for very large datasets

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Mar 1, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants