-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] dummy supervised regressor with polars support #440
Comments
@fkiraly I've come into a problem with the current implementation for if an estimator specifies
Then during the tests, pandas DataFrames will get converted into polars dataframes via Since the index is already lost via the boilerplate code |
Interesting - I thought it saved the index as a variable Or, is that only in the |
I think that would be in the |
May I suggest to try syncing the two implementations? I think the |
adds index support as part of #440 and is used to sync up polars conversion utilities between skpro and sktime. Correponding sktime pr for polars conversion utilities is sktime/sktime#6455. In this pr: If a pandas Dataframe is a `from_type` and polars frame is a `to_type` then during the conversion, we will save the index (assumed never to be in multi-index format) and insert it as an individual column with column name `__index__`. Then the resulting pandas dataframe will be converted to a polars dataframe. In the inverse function, if we are converting from polars dataframe to pandas dataframe, if the column `__index__` exists in the pandas dataframe post-conversion, then we will map that column to the index before returning the pandas Dataframe After this is merged, #447 will be implemented as a `polars` only estimator. tests will also be written to check polars input end to end and pandas input and output through the polars estimator (i.e pandas input into polars estimator -> polars predictions -> pandas output)
Implement the
DummyProbaRegressor
but with complete end to end support inskpro
.Some current limitations:
fit
insideDummyProbaRegressor
usesskpro.distributions
which only supports pandas dataframes - needs a workaroundpredict_proba
also usesskpro.distributions
- leading to the same issue, will need a workaround as well@fkiraly any suggestions on how to implement?
The text was updated successfully, but these errors were encountered: