Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Synchronize dependency checker with sktime counterpart #490

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

meraldoantonio
Copy link
Contributor

@meraldoantonio meraldoantonio commented Nov 12, 2024

Reference Issues/PRs

Potentially fixes failing tests in #358 (failing Python tests)
Addresses issue #489

What does this implement/fix? Explain your changes.

Synchronized dependency checking utilities in utils with the one from sktime

The current version is a fork of a much earlier version of sktime and is problematic as it must import packages in order to check presence of dependencies. This is causing the failures in the test collection phase in #358, or more generally, in a case where the imported package is faulty, with import causing exceptions.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Compatibility of the content with the wider skpro ecosystem

Did you add any tests for the change?

Yes, I copied the corresponding dependency test test_show_versions from sktime

Any other comments?

No

PR checklist

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

@meraldoantonio meraldoantonio changed the title [BUG] - Synchronized dependency checker with sktime counterpart [ENH] - Synchronized dependency checker with sktime counterpart Nov 12, 2024
@fkiraly fkiraly changed the title [ENH] - Synchronized dependency checker with sktime counterpart [ENH] Synchronize dependency checker with sktime counterpart Nov 13, 2024
@fkiraly fkiraly added enhancement module:base-framework BaseObject, registry, base framework labels Nov 13, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I think you also need to update the tests or they will run out of sync.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Before we merge, have you checked whether this fixes the failure in the other PR now?

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 16, 2024

I´ll just merge and we will see.

@fkiraly fkiraly merged commit a478466 into sktime:main Nov 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:base-framework BaseObject, registry, base framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants