Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lyrics.com provider #25

Open
skuill opened this issue Aug 20, 2024 · 3 comments
Open

Add Lyrics.com provider #25

skuill opened this issue Aug 20, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@skuill
Copy link
Owner

skuill commented Aug 20, 2024

Site: https://www.lyrics.com/
Example:
https://www.lyrics.com/lyric/28902935/Parkway+Drive/Dark+Days

Note: The only problem with the implementation is that there is some unique identifier in the URL, which must be taken from somewhere in order to correctly compose the request URL.

The correct URI for the song lyrics can be found on the artist's page. (the similar logic was used in the #38):

Image

@skuill skuill added enhancement New feature or request good first issue Good for newcomers labels Jan 9, 2025
@skuill
Copy link
Owner Author

skuill commented Feb 3, 2025

Hey @Lukeuke!
If you're still interested in trying to write code for this provider, I wrote in the comment above how we can get the correct URI for the lyrics.

@Lukeuke
Copy link
Contributor

Lukeuke commented Feb 3, 2025

Sure, I will take a look in my free time between my exam session

@skuill
Copy link
Owner Author

skuill commented Feb 4, 2025

@Lukeuke great, and good like with your exams :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants