From a33bf84edc28f3690c6f221762d118dd562c0127 Mon Sep 17 00:00:00 2001 From: John David Taylor Date: Fri, 10 Jan 2025 10:56:29 -0500 Subject: [PATCH] Locationbugfix (#531) * Random feature thoughts. * Fixed a newly introduced bug that causes the diagnostics activity to crash with an NPE. --------- Co-authored-by: JayDeeTay --- app/build.gradle | 4 ++-- .../stardroid/control/AbstractController.java | 5 ++++- designdocs/ux.md | 17 +++++++++++++++++ 3 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 designdocs/ux.md diff --git a/app/build.gradle b/app/build.gradle index 18e6af18..850680a2 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -50,8 +50,8 @@ android { applicationId 'com.google.android.stardroid' minSdk 26 targetSdk 34 // 35 breaks the UI - versionCode 1559 - versionName "1.10.8" + versionCode 1560 + versionName "1.10.9" buildConfigField 'String', 'GOOGLE_ANALYTICS_CODE', '""' testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } diff --git a/app/src/main/java/com/google/android/stardroid/control/AbstractController.java b/app/src/main/java/com/google/android/stardroid/control/AbstractController.java index 8467e6d3..0599eb09 100644 --- a/app/src/main/java/com/google/android/stardroid/control/AbstractController.java +++ b/app/src/main/java/com/google/android/stardroid/control/AbstractController.java @@ -27,7 +27,10 @@ */ public abstract class AbstractController implements Controller { private static final String TAG = MiscUtil.getTag(AbstractController.class); - protected AstronomerModel model; + + // This needs the inject annotation because *some* controllers are inject + // *sometimes* because the job of converting everything to dagger wasn't completed. + @Inject AstronomerModel model; protected boolean enabled = true; @Override diff --git a/designdocs/ux.md b/designdocs/ux.md new file mode 100644 index 00000000..8087e5fa --- /dev/null +++ b/designdocs/ux.md @@ -0,0 +1,17 @@ +# Overall UX +## Random feature ideas +* Do away with the initial splash screen (except maybe on first run?) +* Start outside of the celestial sphere and fly forwards into it +* Have different astronomical bodies at different radii - maybe this could be used to account for slight differences in parallax depending on place on Earth +* Fly to other locations? Be on the moon looking back at Earth? +* Touch an object for more information (obviously) +* Configurable UI to account for accessibility preferences +* Remove likely underused features like layers from the main UI +* Can you find a more intuitive way to switch to manual mode? +* Compass compensation +* Camera mode +* Notifications +* Set/rise times +* OTA updates +* Real horizon +* \ No newline at end of file