Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cyrillic and Polish characters #289

Open
jmmelko opened this issue Apr 14, 2024 · 1 comment
Open

Support for Cyrillic and Polish characters #289

jmmelko opened this issue Apr 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jmmelko
Copy link
Collaborator

jmmelko commented Apr 14, 2024

Polish characters are not supported by the PNG renderer because the NotoSansCJK font was chosen for Western and Asian characters.

Most likely Cyrillic characters are not supported either.

This could be fixed by:

  • adding a font (Czech is already supported by Western fonts I think)
  • Loading it in Resources (permanently?)
  • Choosing the font by detecting the song language. This is different from detecting the user web browser language…
@jmmelko jmmelko added the enhancement New feature or request label Apr 14, 2024
jmmelko added a commit that referenced this issue Apr 16, 2024
@jmmelko
Copy link
Collaborator Author

jmmelko commented Apr 18, 2024

Ok, I think this is fixed, excepted that diacritical marks are shifted rights with respect to base characters when rendered with PIL.
It seems that the fix is to use a library called raqm, but this requires a special installation step, and under windows to download an unofficial DLL and put in the same files as Python.exe:

python-pillow/Pillow#6258

this looks a bit overkill for supporting very rarely used languages.

jmmelko added a commit that referenced this issue Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant