Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add .net standard library support #14

Open
litan1106 opened this issue Aug 24, 2020 · 9 comments
Open

Feature request: Add .net standard library support #14

litan1106 opened this issue Aug 24, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@litan1106
Copy link

Problem:
I couldn't use this library in a N-Tier architecture application.

Solution:
It would be great to have the interfaces move to a new Skyhop.Mail.Abstractions nuget package.

@synercoder synercoder added the enhancement New feature or request label Aug 25, 2020
@synercoder
Copy link
Collaborator

Might be a good idea, what do you think @corstian?

@corstian
Copy link
Member

Sounds good to me, though I'm not really familiar with an N-Tier architecture, so I'd need some guidance there.

@synercoder synercoder self-assigned this Aug 25, 2020
@synercoder
Copy link
Collaborator

I'll pick it up somewhere in the near-future

@synercoder
Copy link
Collaborator

We'll talk it over on Skype somewhere this/next week. Sounds good?

@corstian
Copy link
Member

Yep, just back from holiday so I'm good to go. Just give me a call when it fits.

@litan1106
Copy link
Author

litan1106 commented Aug 25, 2020

Sounds good to me, though I'm not really familiar with an N-Tier architecture, so I'd need some guidance there.

Here is a great example of N-Tier real world application.

https://github.com/dotnet-architecture/eShopOnWeb

https://github.com/ardalis/CleanArchitecture

@synercoder synercoder reopened this Oct 2, 2020
@synercoder
Copy link
Collaborator

Time slipped by, pandemic f*cks with your sense of time... Still assigned to me, and will try to pick it up asap.

@corstian
Copy link
Member

@litan1106 @synercoder It took a while to get there, but there's an open pull request #15 where I split the project into two packages;

  1. Skyhop.Mail
  2. Skyhop.Mail.Abstractions

Would this fit well within an n-tiered architecture and solve the current problems?

Some changes along the way;

  1. All interface have been put in the Abstractions package
  2. There's a new IMailDispatcher interface.
  3. The MailBase class has been moved to the Abstractions package, and the BodyBuilder within has been made public get-only.

@corstian
Copy link
Member

The 3.0.0-rc5 version has been pushed to NuGet, and contains these libraries; https://www.nuget.org/packages/Skyhop.Mail/3.0.0-rc5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants