Creating Custom Probe for jsonapi-rb

[thegranddesign]

I noticed in your AMS Probe all you're really doing is making sure that instrumentation happens.

Because AMS's development has basically been stagnant for years, I've switched to jsonapi-rb which is a much better designed library and is split up into micro-libraries that each do only one thing well.

I would like to create a probe for jsonapi-rails (just wrapper for jsonapi-rb). jsonapi-rails already adds instrumentation for both its serialization and deserialization, so what would be the most expedient way for me to create a probe for these two instrumentation items?

[wycats]

@wagenet @chancancode should we make (at least some subset of) the probe API public? I think that's the best solution to this problem.

[wagenet]

Probes only make sense for things actually included in the Skylight gem. That said, we should document the code more clearly to make it easier for people to send PRs.

[wagenet]

@thegranddesign in the case of jsonapi-rails, it uses AS::N, so you can just make a normalizer instead. No need for a probe. Let me know if you have questions about how to do that.

[thegranddesign]

@wagenet and then I would need to submit a PR to get that into the gem?

[wagenet]

@thegranddesign ideally :)

If you didn't want to integrate it, you could always subscribe to the AS::N notifications on your own and then call Skylight.instrument from them.

[rromanchuk]

also, FYI looks like latest release broke instrumentation over at Netflix/fast_jsonapi#202 (comment)

[hmcfletch]

@rromanchuk #120