Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism to ensure protobuf generated code is kept up to date #16

Open
geoffxy opened this issue Dec 6, 2019 · 0 comments
Open

Mechanism to ensure protobuf generated code is kept up to date #16

geoffxy opened this issue Dec 6, 2019 · 0 comments
Labels
devinfra This is related to development infrastructure tech debt This should be improved

Comments

@geoffxy
Copy link
Member

geoffxy commented Dec 6, 2019

When we update protobuf files, we need to ensure that the developer does not forget to check in the updated generated code. One way to accomplish this could be to use a git hook to warn* users if changes to protobuf files are not accompanied by changes to the generated code.

*We want to warn users because there are certain changes that will not change the generated code (e.g., changing comments in the protobuf file).

@geoffxy geoffxy added tech debt This should be improved devinfra This is related to development infrastructure labels Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devinfra This is related to development infrastructure tech debt This should be improved
Projects
None yet
Development

No branches or pull requests

1 participant