Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sequence number wraparound #21

Open
geoffxy opened this issue Dec 25, 2019 · 0 comments
Open

Handle sequence number wraparound #21

geoffxy opened this issue Dec 25, 2019 · 0 comments
Labels
plugin This is primarily related to the Atom plugin server This is primarily related to the server

Comments

@geoffxy
Copy link
Member

geoffxy commented Dec 25, 2019

We use 32-bit unsigned integers to represent a message's sequence number. We assume that the sequence number increases monotonically. However when we reach 2^32-1, the next sequence number will be 0.

Given that we start at a sequence number of 0, it is unlikely for a user to hit 2^32-1 in a single session. However it would be a good idea to handle this wraparound for correctness.

@geoffxy geoffxy added plugin This is primarily related to the Atom plugin server This is primarily related to the server labels Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin This is primarily related to the Atom plugin server This is primarily related to the server
Projects
None yet
Development

No branches or pull requests

1 participant