Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Pre-flight checks for opening ports #3144

Closed
romilbhardwaj opened this issue Feb 10, 2024 · 5 comments
Closed

[k8s] Pre-flight checks for opening ports #3144

romilbhardwaj opened this issue Feb 10, 2024 · 5 comments
Labels
k8s Kubernetes related items Stale

Comments

@romilbhardwaj
Copy link
Collaborator

Currently if the user does not have loadbalancer or ingress controller deployed, sky launch with ports will succeed but ports will never be exposed. We should add checks before sky launch to make sure the cluster will be able to open ports.

cc @Michaelvll
@romilbhardwaj romilbhardwaj added the k8s Kubernetes related items label Feb 10, 2024
@github-actions github-actions bot added the Stale label Jun 9, 2024
@skypilot-org skypilot-org deleted a comment from github-actions bot Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
@romilbhardwaj
Copy link
Collaborator Author

Reopening. This is important for k8s UX.

@romilbhardwaj romilbhardwaj reopened this Oct 20, 2024
@github-actions github-actions bot removed the Stale label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
k8s Kubernetes related items Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romilbhardwaj