Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver compatible version in Foundation\Application #20

Open
luceos opened this issue Jun 6, 2018 · 1 comment
Open

Semver compatible version in Foundation\Application #20

luceos opened this issue Jun 6, 2018 · 1 comment

Comments

@luceos
Copy link

luceos commented Jun 6, 2018

const VERSION = '0.1.0-beta.7C';

Hello @skywalker512,

I have not come to pester you with copyrights (at this point). People installing your version are also installing Bazaar. Your version appends a letter to the Flarum version, eg 0.1.0-beta.7C which is not semver compliant. As such any user with your version of Flarum will cause an error on the API of flagrow.io and will have a bad experience using Bazaar because it won't work for them.

I suggest using a semver compliant versioning scheme by using meta, eg 0.1.0-beta.7+flarumchina.c which would allow the flagrow.io api to be able to properly parse the flarum version and provide compatible packages.

Thank you for your consideration!

@skywalker512
Copy link
Owner

Thank for your information. I will change this in next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants