fix a mistake in byrow argmax and argmin (#62)

threads argument should be passed to inner calls
sl-solution · Jun 1, 2022 · 4220d4b · 4220d4b
1 parent ee78f24
commit 4220d4b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/byrow/row_functions.jl b/src/byrow/row_functions.jl
@@ -625,7 +625,7 @@ end
 
 function row_argmin(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}); threads = true)
     colsidx = multiple_getindex(index(ds), cols)
-    minvals = row_minimum(ds, f, cols)
+    minvals = row_minimum(ds, f, cols; threads = threads)
     colnames_pa = allowmissing(PooledArray(_names(ds)[colsidx]))
     push!(colnames_pa, missing)
     missref = get(colnames_pa.invpool, missing, missing)
@@ -651,7 +651,7 @@ row_argmin(ds::AbstractDataset, cols = names(ds, Union{Missing, Number}); thread
 
 function row_argmax(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}); threads = true)
     colsidx = multiple_getindex(index(ds), cols)
-    maxvals = row_maximum(ds, f, cols)
+    maxvals = row_maximum(ds, f, cols; threads = threads)
     colnames_pa = allowmissing(PooledArray(_names(ds)[colsidx]))
     push!(colnames_pa, missing)
     missref = get(colnames_pa.invpool, missing, missing)