From 4220d4bdc03e95098c498ed4012b6bee8fe50eb1 Mon Sep 17 00:00:00 2001 From: giantmoa <105028047+giantmoa@users.noreply.github.com> Date: Wed, 1 Jun 2022 19:58:43 +1200 Subject: [PATCH] fix a mistake in byrow argmax and argmin (#62) threads argument should be passed to inner calls --- src/byrow/row_functions.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/byrow/row_functions.jl b/src/byrow/row_functions.jl index 05801fb4..f7f4058e 100644 --- a/src/byrow/row_functions.jl +++ b/src/byrow/row_functions.jl @@ -625,7 +625,7 @@ end function row_argmin(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}); threads = true) colsidx = multiple_getindex(index(ds), cols) - minvals = row_minimum(ds, f, cols) + minvals = row_minimum(ds, f, cols; threads = threads) colnames_pa = allowmissing(PooledArray(_names(ds)[colsidx])) push!(colnames_pa, missing) missref = get(colnames_pa.invpool, missing, missing) @@ -651,7 +651,7 @@ row_argmin(ds::AbstractDataset, cols = names(ds, Union{Missing, Number}); thread function row_argmax(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}); threads = true) colsidx = multiple_getindex(index(ds), cols) - maxvals = row_maximum(ds, f, cols) + maxvals = row_maximum(ds, f, cols; threads = threads) colnames_pa = allowmissing(PooledArray(_names(ds)[colsidx])) push!(colnames_pa, missing) missref = get(colnames_pa.invpool, missing, missing)