Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings while running tests #78

Open
gitboy16 opened this issue Aug 19, 2022 · 1 comment
Open

Warnings while running tests #78

gitboy16 opened this issue Aug 19, 2022 · 1 comment

Comments

@gitboy16
Copy link

Hi,
I got the following warning twice while running tests on Julia 1.8.

Warning: broadcasting get property is deprecated for SubDataset and will be disallowed in the future. Use `ds[:, :x2] .= ... instead
  caller = macro expansion at broadcasting.jl:171 [inlined]

I am not sure whether it is intended or not. If yes maybe worth using @test_warn ?
Also, just a suggestion, maybe use @testset to make the test summary nicer?

Thank you

@sl-solution
Copy link
Owner

It should not be there because we have not supported "broadcasting get property" since day one. The reason why it is still there is because we copied some of those tests from DataFrames.jl and I did not polish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants