Skip to content

Commit 1504e69

Browse files
committed
Simplify stats collector logic
1 parent a76c95e commit 1504e69

File tree

1 file changed

+11
-18
lines changed

1 file changed

+11
-18
lines changed

kaldb/src/main/java/com/slack/kaldb/logstore/search/StatsCollector.java

+11-18
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@
55
import java.io.IOException;
66
import org.apache.lucene.index.LeafReaderContext;
77
import org.apache.lucene.index.NumericDocValues;
8-
import org.apache.lucene.search.Collector;
9-
import org.apache.lucene.search.LeafCollector;
10-
import org.apache.lucene.search.Scorable;
118
import org.apache.lucene.search.ScoreMode;
9+
import org.apache.lucene.search.SimpleCollector;
1210

13-
public class StatsCollector implements Collector {
11+
public class StatsCollector extends SimpleCollector {
1412

1513
public final Histogram histogram;
1614
private NumericDocValues docValues;
@@ -22,21 +20,8 @@ public StatsCollector(Histogram histogram) {
2220
}
2321

2422
@Override
25-
public LeafCollector getLeafCollector(LeafReaderContext context) throws IOException {
23+
protected void doSetNextReader(final LeafReaderContext context) throws IOException {
2624
docValues = context.reader().getNumericDocValues(SystemField.TIME_SINCE_EPOCH.fieldName);
27-
28-
return new LeafCollector() {
29-
@Override
30-
public void setScorer(Scorable scorer) {}
31-
32-
@Override
33-
public void collect(int doc) throws IOException {
34-
if (docValues != null && docValues.advanceExact(doc)) {
35-
long timestamp = docValues.longValue();
36-
histogram.add(timestamp);
37-
}
38-
}
39-
};
4025
}
4126

4227
public Histogram getHistogram() {
@@ -47,4 +32,12 @@ public Histogram getHistogram() {
4732
public ScoreMode scoreMode() {
4833
return ScoreMode.COMPLETE_NO_SCORES;
4934
}
35+
36+
@Override
37+
public void collect(int doc) throws IOException {
38+
if (docValues != null && docValues.advanceExact(doc)) {
39+
long timestamp = docValues.longValue();
40+
histogram.add(timestamp);
41+
}
42+
}
5043
}

0 commit comments

Comments
 (0)