Add further testing to CountStar formatting

Signed-off-by: Tim Vaillancourt <[email protected]>

go/vt/sqlparser/ast_format.go

@@ -2656,12 +2656,12 @@ func (node *Count) Format(buf *TrackedBuffer) {
 }
 
 func (node *CountStar) Format(buf *TrackedBuffer) {
+	name := node.AggrName()
 	if node.Name != "" {
-		buf.astPrintf(node, "%s(*)", node.Name)
-	} else {
-		buf.astPrintf(node, "%s(", node.AggrName())
-		buf.WriteString("*)")
+		name = node.Name
 	}
+	buf.astPrintf(node, "%s(", name)
+	buf.WriteString("*)")
 }
 
 func (node *Avg) Format(buf *TrackedBuffer) {

go/vt/sqlparser/ast_format_fast_test.go

@@ -0,0 +1,28 @@
+package sqlparser
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCountStarFormatFast(t *testing.T) {
+	{
+		buf := NewTrackedBuffer(nil)
+		node := &CountStar{}
+		node.formatFast(buf)
+		assert.Equal(t, &ParsedQuery{Query: "count(*)"}, buf.ParsedQuery())
+	}
+	{
+		buf := NewTrackedBuffer(nil)
+		node := &CountStar{Name: "Count"}
+		node.formatFast(buf)
+		assert.Equal(t, &ParsedQuery{Query: "Count(*)"}, buf.ParsedQuery())
+	}
+	{
+		buf := NewTrackedBuffer(nil)
+		node := &CountStar{Name: "COUNT"}
+		node.formatFast(buf)
+		assert.Equal(t, &ParsedQuery{Query: "COUNT(*)"}, buf.ParsedQuery())
+	}
+}

go/vt/sqlparser/ast_format_test.go

@@ -0,0 +1,28 @@
+package sqlparser
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCountStarFormat(t *testing.T) {
+	{
+		buf := NewTrackedBuffer(nil)
+		node := &CountStar{}
+		node.Format(buf)
+		assert.Equal(t, &ParsedQuery{Query: "count(*)"}, buf.ParsedQuery())
+	}
+	{
+		buf := NewTrackedBuffer(nil)
+		node := &CountStar{Name: "Count"}
+		node.Format(buf)
+		assert.Equal(t, &ParsedQuery{Query: "Count(*)"}, buf.ParsedQuery())
+	}
+	{
+		buf := NewTrackedBuffer(nil)
+		node := &CountStar{Name: "COUNT"}
+		node.Format(buf)
+		assert.Equal(t, &ParsedQuery{Query: "COUNT(*)"}, buf.ParsedQuery())
+	}
+}