From 696c303335a9674187467c7edd9c01a461a0417a Mon Sep 17 00:00:00 2001 From: YektaY Date: Fri, 20 Dec 2024 11:16:33 -0800 Subject: [PATCH 1/2] round and cast to int every change while dragging the slider handle to prevent a value error --- pydm/widgets/slider.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pydm/widgets/slider.py b/pydm/widgets/slider.py index 041120bad..2ca209f23 100644 --- a/pydm/widgets/slider.py +++ b/pydm/widgets/slider.py @@ -78,9 +78,9 @@ def mouseMoveEvent(self, event): delta = event.pos() - self.dragStartPos if self.orientation() == Qt.Horizontal: - delta_value = (delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum()) + delta_value = int(round((delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum()))) else: - delta_value = (-delta.y() / self.getSliderLength()) * (self.maximum() - self.minimum()) + delta_value = int(round((-delta.y() / self.getSliderLength()) * (self.maximum() - self.minimum()))) new_value = self.dragStartValue + delta_value new_value = min(max(self.minimum(), new_value), self.maximum()) From 69adcfbc10b82b784033d2ada14e9515d355ed39 Mon Sep 17 00:00:00 2001 From: YektaY Date: Sat, 21 Dec 2024 09:43:36 -0800 Subject: [PATCH 2/2] removed int casting --- pydm/widgets/slider.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pydm/widgets/slider.py b/pydm/widgets/slider.py index 2ca209f23..1bb2a16d4 100644 --- a/pydm/widgets/slider.py +++ b/pydm/widgets/slider.py @@ -78,10 +78,9 @@ def mouseMoveEvent(self, event): delta = event.pos() - self.dragStartPos if self.orientation() == Qt.Horizontal: - delta_value = int(round((delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum()))) + delta_value = round((delta.x() / self.getSliderLength()) * (self.maximum() - self.minimum())) else: - delta_value = int(round((-delta.y() / self.getSliderLength()) * (self.maximum() - self.minimum()))) - + delta_value = round((-delta.y() / self.getSliderLength()) * (self.maximum() - self.minimum())) new_value = self.dragStartValue + delta_value new_value = min(max(self.minimum(), new_value), self.maximum()) self.setValue(new_value)