Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Only checking for the registry entry might not be a valid way to check if Java is installed. #501

Open
moritzgloeckl opened this issue Aug 8, 2019 · 0 comments

Comments

@moritzgloeckl
Copy link

moritzgloeckl commented Aug 8, 2019

Tailor Version: v0.12.0
Platform (Mac/Linux/Windows/CI): Windows
Installation Method: Powershell Script

I have installed java version "11.0.4" 2019-07-16 LTS on my Windows 10 machine and correctly set the JAVA_HOME environment variable.

The HKLM:\SOFTWARE\JavaSoft\Java Runtime Environment does not exist on my machine, thus trying to install resolved in an error. There's a HKLM:\SOFTWARE\JavaSoft\JDK\11 though. Commenting the verify-java() function in the .ps1 script installs tailor successfully.

Maybe checking for which java or something similar is better than checking for the registry entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant