Calender view not working with recent software for TYPO3 12

[stweil]

Working link with official DFG Viewer (which uses older code) shows all years:
https://dfg-viewer.de/show?tx_dlf%5Bid%5D=https%3A%2F%2Fdigital.ladenburg.world%2Fdata/Ladenburger_Wochenblatt/mets.xml

Test with local installation (based on recent code):
http://localhost/viewer?tx_dlf%5Bid%5D=https%3A%2F%2Fdigital.ladenburg.world%2Fdata/Ladenburger_Wochenblatt/mets.xml
redirects to
http://localhost/viewer?tx_dlf_calendar%5Baction%5D=years&tx_dlf_calendar%5Bcontroller%5D=Calendar&tx_dlf_calendar%5Bdouble%5D=0&tx_dlf_calendar%5Bid%5D=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FLadenburger_Wochenblatt%2Fmets.xml&tx_dlf_calendar%5Bpage%5D=1&cHash=2cfa758bd98ef9165daf956e563678f8
which only shows an empty viewer page.

The software was installed on Debian bullseye using the commands from https://github.com/UB-Mannheim/kitodo-presentation/wiki/Testumgebung-mit-Podman#installation-dfg-viewer-with-typo3-12.

[stweil]

Not only the anchor mets fails with recent code, but also the mets for a year.

Working link with official DFG Viewer shows all months and days of the selected year:
https://dfg-viewer.de/show?tx_dlf[id]=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FLadenburger_Wochenblatt%2Fmets_1900.xml

Test with local installation:
http://localhost/viewer?tx_dlf[id]=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FLadenburger_Wochenblatt%2Fmets_1900.xml
redirects to
http://localhost/viewer?tx_dlf_calendar%5Baction%5D=calendar&tx_dlf_calendar%5Bcontroller%5D=Calendar&tx_dlf_calendar%5Bdouble%5D=0&tx_dlf_calendar%5Bid%5D=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FLadenburger_Wochenblatt%2Fmets_1900.xml&tx_dlf_calendar%5Bpage%5D=1&cHash=11eb274d2e6938c0ac3ef410732f309c
which also does not work.

[stweil]

A mets file for an issue works with the official DFG Viewer and shows the first page of the issue:
https://dfg-viewer.de/show?tx_dlf[id]=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FLadenburger_Wochenblatt%2Fmets_19000602.xml

It also works with the local installation:
http://localhost/viewer?tx_dlf[id]=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FLadenburger_Wochenblatt%2Fmets_19000602.xml

[stweil]

Anchor, year and issue views work with TYPO3 11 if the patches for TYPO3 12 are not applied.

[beatrycze-volk]

Is it possible that reason for it is that DFG Viewer is not yet TYPO3 12 compatible?

[stweil]

Yes, that's why I used my fork with the pull request #322 for the test with TYPO3 12.
The successful test with TYPO3 11 was based on the official repositories.

[stweil]

Unrelated: I think the square brackets in tx_dlf[id] should be encoded. This seems to be a minor bug (probably in Kitodo.Presentation) which exists for a long time now and is still in master.

[markusweigelt]

Yes, that's why I used my fork with the pull request #322 for the test with TYPO3 12. The successful test with TYPO3 11 was based on the official repositories.

I find this a bit confusing, as you're referring to the #322 in this comment rather than in the description of this issue. The description makes it sound like TYPO3 12 was installed with the state from the DFG-Viewer master.

In the #322, I didn't take the calendar view into account, but I could fix that soon. It would be helpful if we could collect the test scenarios so that we can go through all of them at once.

Unrelated: I think the square brackets in tx_dlf[id] should be encoded. This seems to be a minor bug (probably in Kitodo.Presentation) which exists for a long time now and is still in master.

Don't you think it would be better to create an issue in Kitodo.Presentation if you already suspect this? It will probably get overlooked here.

[stweil]

I find this a bit confusing, as you're referring to the #322 in this comment rather than in the description of this issue. The description makes it sound like TYPO3 12 was installed with the state from the DFG-Viewer master.

Yes, you are right. My only excuse is that I also have to sort things for me and find the reasons for failures in my tests. When I created the issue I did not know that it was related to TYPO3 12 and your pull request.