Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong display of "Kontext" in viewer for years and issues of newspaper #328

Open
stweil opened this issue Dec 10, 2024 · 5 comments
Open
Labels
🐛 bug A non-security related bug.

Comments

@stweil
Copy link
Contributor

stweil commented Dec 10, 2024

The official DFG Viewer shows correct metadata: https://dfg-viewer.de/show?tx_dlf%5Bid%5D=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FNeckar-Bergstrass-Post%2Fmets_1925.xml

Titel
    Neckar-Bergstraß-Post
Kontext
    Neckar-Bergstraß-Post
Erscheinungsort
    Ladenburg

A test installation with TYPO3 11 and the official master branches shows wrong metadata for "Kontext": http://localhost/viewer?tx_dlf%5Bid%5D=https%3A%2F%2Fdigital.ladenburg.world%2Fdata%2FNeckar-Bergstrass-Post%2Fmets_1925.xml

Titel
    Neckar-Bergstraß-Post
Kontext
    Neckar-Bergstraß-Post >
Erscheinungsort
    Ladenburg

Note the additional ">". The HTML code shows a wrong encoding (missing ";"):

<dt>Kontext</dt><dd>
        Ladenburger Wochenblatt &gt</dd>
@stweil
Copy link
Contributor Author

stweil commented Dec 10, 2024

The wrong "Kontext" is not only shown in the calendar view for a single year, but also in the viewer for a single newspaper issue.

@stweil
Copy link
Contributor Author

stweil commented Dec 10, 2024

I noticed the wrong encoding &gt instead of &gt; while I validated the HTML code with the W3C validator.

@stweil
Copy link
Contributor Author

stweil commented Dec 10, 2024

Unrelated question: I wanted to test SRU, added a <dv:sru> entry to my METS files, but don't see any effect in the DFG Viewer (neither at dfg-viewer.de nor in a local test installation). How can I get a search field? Is there a working example somewhere?

@stweil
Copy link
Contributor Author

stweil commented Dec 13, 2024

Another display error is shown in the viewer for the whole newspaper ("Gesamtausgabe", anchor METS file): http://localhost/viewer?tx_dlf[id]=https%3A%2F%2Fdigital.ladenburg.de%2Fdata%2FNeckar-Bergstrass-Post%2Fmets.xml

Titel
    Neckar-Bergstraß-Post
Erscheinungsverlauf
    01.11.1919 - 31.05.1941,
Erscheinungsort
    Ladenburg
Erscheinungsjahr
    1919-11-01

Note the comma behind "31.05.1941". Here is the HTML code:

 <dt>Erscheinungsverlauf</dt>
 <dd>01.11.1919 - 31.05.1941</dd>,

@stweil
Copy link
Contributor Author

stweil commented Dec 13, 2024

Unrelated question: I wanted to test SRU, added a <dv:sru> entry to my METS files, but don't see any effect in the DFG Viewer (neither at dfg-viewer.de nor in a local test installation). How can I get a search field? Is there a working example somewhere?

I found the solution in the source code of slub_digitalcollections, not in the documentation (METS-Anwendungsprofil_2.3.1.pdf, SRU-ALTO-Anwendungsprofil_1.0.pdf). The SRU entry is expected below <mets:digiprovMD>:

  <amdSec ID="amd_01">
    <digiprovMD ID="digiprov_01">
      <mdWrap MDTYPE="OTHER" OTHERMDTYPE="DVLINKS">
        <xmlData>
          <dv:links>
            <dv:sru>http://HOST/PATH</dv:sru>
          </dv:links>
        </xmlData>
      </mdWrap>
    </digiprovMD>
  [...]

@sebastian-meyer, is this a documentation issue, or did I look at the wrong place?

@beatrycze-volk beatrycze-volk added the 🐛 bug A non-security related bug. label Dec 17, 2024
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 6.2.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

No branches or pull requests

2 participants