Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken SRU search with recent code #331

Open
stweil opened this issue Dec 15, 2024 · 2 comments
Open

Broken SRU search with recent code #331

stweil opened this issue Dec 15, 2024 · 2 comments
Labels
🐛 bug A non-security related bug.

Comments

@stweil
Copy link
Contributor

stweil commented Dec 15, 2024

Official DFG Viewer (old code) with SRU example from documentation:

Bildschirmfoto 2024-12-15 um 17 11 33

Latest code with TYPO3:

Bildschirmfoto 2024-12-15 um 17 08 37
@stweil
Copy link
Contributor Author

stweil commented Dec 15, 2024

In the test above only the <dv:span class="highlight">Posten</dv:span> was returned.

If there are also <span> elements without class="highlight" like in the official documentation and in the following XML, the latest code hangs with "Lade Ergebnisse ...".

<srw:searchRetrieveResponse>
  <srw:version>1.2</srw:version>
  <srw:numberOfRecords>1</srw:numberOfRecords>
  <srw:records>
    <srw:record>
      <srw:recordSchema>dfg-viewer/page</srw:recordSchema>
      <srw:recordPacking>xml</srw:recordPacking>
      <srw:recordData>
        <dv:page id="phys30439" width="2215" height="3076" url="https://visuallibrary.net/download/webcache/0/30439">
          <dv:parent id="log228591" url="https://visuallibrary.net/mets/vd/id/228591">20.8.1854 (No. 34</dv:parent>
          <dv:pagination>268</dv:pagination>
          <dv:fulltexthit x1="1561" y1="1229" x2="1669" y2="1275" preview="https://visuallibrary.net/search/pagecrop?id=30439&amp;term=post">
            <dv:span>vorzüglich berufen. Als daher der damit bethcilte </dv:span>
            <dv:span class="highlight">Posten</dv:span>
            <dv:span>eines Gubernialraihes zu Innsbruck zu besetzen kam, erfolgte</dv:span>
          </dv:fulltexthit>
        </dv:page>
      </srw:recordData>
    </srw:record>
  </srw:records>
</srw:searchRetrieveResponse>

@stweil
Copy link
Contributor Author

stweil commented Dec 16, 2024

I get the same errors with release v6.1.2.

@beatrycze-volk beatrycze-volk added the 🐛 bug A non-security related bug. label Dec 17, 2024
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 6.2.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

No branches or pull requests

2 participants