Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TEI validation errors #44

Open
wrznr opened this issue May 26, 2020 · 2 comments
Open

Fix TEI validation errors #44

wrznr opened this issue May 26, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@wrznr
Copy link
Member

wrznr commented May 26, 2020

After consultation with @tboenig, it turns out that with a few modifications we can reach full compatibility with the DTABf, almost:

  • collection information as textclass
  • extentbiblFull
  • licence target attribute
  • editionStmt one level higher
  • titlePagediv type="titlePage"
@wrznr wrznr added the enhancement New feature or request label May 26, 2020
@wrznr wrznr self-assigned this May 26, 2020
@bertsky
Copy link
Member

bertsky commented Dec 20, 2021

  • collection information as textclass

We should reserve the tei:profileDesc/tei:textClass mechanism for mods:subject and mods:classification, as implemented here.

The proper representation for mods:relatedItem/@type=series is not tei:creation, but tei:msDesc/tei:msIdentifier/tei:collection IMO, as implemented here.

  • editionStmt one level higher

Fixed here

In addition to the above, when validating against TEI itself (xmlstarlet val -r tei_all.rng tei.xml), one can immediately see lots of invalidities caused by wrong order of elements. (For example, under tei:publicationStmt, we need publisher < date < pubPlace < idno < availability, whereas we do add_place < add_date < add_publisher < set_availability < add_identifier.)

@bertsky
Copy link
Member

bertsky commented Jan 10, 2022

The proper representation for mods:relatedItem/@type=series is not tei:creation, but tei:msDesc/tei:msIdentifier/tei:collection IMO, as implemented here.

  • editionStmt one level higher

Fixed here

Not a fix, because not in DTABf either, see discussion here. So let's move mods:relatedItem/@type=series into sourceDesc/biblFull/seriesStmt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants