diff --git a/src/Mods/Element/Note.php b/src/Mods/Element/Note.php index 55eaf8f..08bc8e3 100644 --- a/src/Mods/Element/Note.php +++ b/src/Mods/Element/Note.php @@ -21,6 +21,7 @@ /** * Note MODS metadata element class for the 'php-mods-reader' library. + * @see https://www.loc.gov/standards/mods/userguide/note.html * * @access public */ @@ -43,7 +44,8 @@ public function __construct(\SimpleXMLElement $xml) } /** - * Get the value of type + * Get the value of the 'type' attribute. + * @see https://www.loc.gov/standards/mods/userguide/note.html * * @access public * diff --git a/src/Mods/Element/PhysicalDescription.php b/src/Mods/Element/PhysicalDescription.php index 97511d2..c0942b8 100644 --- a/src/Mods/Element/PhysicalDescription.php +++ b/src/Mods/Element/PhysicalDescription.php @@ -22,9 +22,11 @@ use Slub\Mods\Element\Note; use Slub\Mods\Element\Specific\PhysicalDescription\Extent; use Slub\Mods\Element\Specific\PhysicalDescription\Form; +use Slub\Mods\Element\Xml\Element; /** * PhysicalDescription MODS metadata element class for the 'php-mods-reader' library. + * @see https://www.loc.gov/standards/mods/userguide/physicaldescription.html * * @access public */ @@ -32,42 +34,6 @@ class PhysicalDescription extends BaseElement { use LanguageAttribute, IdAttribute, XlinkHrefAttribute, AltRepGroupAttribute, DisplayLabelAttribute; - /** - * @access private - * @var Form - */ - private Form $form; - - /** - * @access private - * @var string - */ - private string $reformattingQuality; - - /** - * @access private - * @var LanguageElement - */ - private LanguageElement $internetMediaType; - - /** - * @access private - * @var Extent - */ - private Extent $extent; - - /** - * @access private - * @var string - */ - private string $digitalOrigin; - - /** - * @access private - * @var Note - */ - private Note $note; - /** * This extracts the essential MODS metadata from XML * @@ -80,84 +46,134 @@ class PhysicalDescription extends BaseElement public function __construct(\SimpleXMLElement $xml) { parent::__construct($xml); - - $this->form = new Form($xml); - $this->reformattingQuality = ''; - $this->internetMediaType = new LanguageElement($xml); - $this->extent = new Extent($xml); - $this->digitalOrigin = ''; - $this->note = new Note($xml); } /** - * Get the value of form + * Get the array of the