Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin esptouch_flutter uses a deprecated version of the Android embedding #19

Open
purevnorov opened this issue Sep 3, 2021 · 9 comments
Labels
prerelease An issue or PR that is fixed in a prerelease

Comments

@purevnorov
Copy link

The plugin esptouch_flutter uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.

@kiranvivo
Copy link

I see this warning too. Any suggestions?

@Polydevelopment1
Copy link

Yes i am seeing this as well, maybe on the next update this can be upgraded to v2 embedding?

@vincevargadev
Copy link
Member

Thank you for letting us know. I'm not sure when we'll have time to do the migration (and the testing required to make sure everything is still running correctly). Community contributions would be welcome.

@vincevargadev vincevargadev added good first issue Good for newcomers and removed good first issue Good for newcomers labels Nov 14, 2021
@aminjoharinia
Copy link

any update plan?

@max-koehler
Copy link
Member

@aminjoharinia as @vincevargadev pointed out there is no plan yet to upgrade and test it.
Having said that, contributions in the form of a PR are welcome.

@SteMMo33
Copy link

SteMMo33 commented Mar 9, 2022

Hello Vince,
I updated the plugin to the Android V2 embedding.
So far I'm able to compile it, compile the example without the V2 warning and run on the Android emulator without errors/crashes - of course the emulator notifies 'no device' cause the WiFi is emulated.
Tomorrow I will receive an ESP32 board and in the week-end I hope to check the app+plugin against a real board.

Regards

vincevargadev added a commit that referenced this issue Mar 27, 2022
Android embedding v2. Includes [PR `#28`](#28). Fixes [`#19`](#19) and [`#29`](#29).
@vincevargadev
Copy link
Member

I published a pre-release version on pub.dev https://pub.dev/packages/esptouch_flutter/versions/1.1.0-androidv2

Please give it a try, and let us know if anything is not working as it did before.

If we don't receive any negative feedback, I'll release it as stable in a couple of weeks.

@vincevargadev vincevargadev added prerelease An issue or PR that is fixed in a prerelease and removed good first issue Good for newcomers labels Mar 27, 2022
@SteMMo33
Copy link

Good news, thanks !!
I updated the plugin with the 1.1.0-androidv2 version:
so far I tested on Android 7.0 API 24 and it worked.
I see some new debug messages on console and in the compilation time I see the following message:

Note: C:\Progetti\flutter\.pub-cache\hosted\pub.dartlang.org\esptouch_flutter-1.1.0-androidv2\android\src\main\java\com\smaho\eng\esptouch\EsptouchPlugin.java uses or overrides a deprecated API.

Soon I will test on iOS.
Thanks a lot!

@nguyen703
Copy link

It works like a charm!

I tested on iOS (16.0.2) and Android (9), the warning message disappeared. Also, I got a debug message like @SteMMo33.

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease An issue or PR that is fixed in a prerelease
Projects
None yet
Development

No branches or pull requests

8 participants