Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of 1.0.0 #13

Open
t1 opened this issue Aug 8, 2023 · 3 comments
Open

Compatibility of 1.0.0 #13

t1 opened this issue Aug 8, 2023 · 3 comments

Comments

@t1
Copy link
Contributor

t1 commented Aug 8, 2023

@jmartisk: I was waiting for the release of 1.0.0 and now saw, that you already did release it two weeks ago 🚀, but my IntelliJ didn't update 🤔. Investigating further, I found that the plugin's versions page shows 1.0.0 to be compatible with 2022.3 - 2022.3.3. I tried to find out what went wrong and it looks like the gradle build magic still creates a plugin.xml with until-build set to 223.* 🤯

I don't feel very comfortable with gradle, maybe you have an idea? Or should we open an issue with JetBrains? Maybe we should set it to 232.* as a workaround for now. What do you think?

@jmartisk
Copy link
Member

jmartisk commented Aug 8, 2023

Hmm. After some tinkering, it seems that "not specifying untilBuild" actually means setting it to an empty string, not null. Please check #14 I think it fixes the problem

@t1
Copy link
Contributor Author

t1 commented Aug 8, 2023

Yes, that seems to help. Thanks!

@t1
Copy link
Contributor Author

t1 commented Aug 11, 2023

Thanks for doing another release. It works just fine. I love you, man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants