-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image tag to alpine/curl #196
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the use of :latest
instead of an explicit version would work for your use case?
@@ -10,7 +10,7 @@ metadata: | |||
spec: | |||
containers: | |||
- name: curl | |||
image: alpine/curl | |||
image: alpine/curl:8.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: alpine/curl:8.10.0 | |
image: alpine/curl:latest |
Yes, that would work as well.
Hi @maraino, yes that should work as well. I created a suggestion from @amitsagtani97's PR, unfortunately he's OOO for a few days/weeks. Please go ahead and merge, if you can. Thanks! |
Description
While using the helm template command to download and ship step-certificates chart in an air-gapped environment, getting this error -
Container alpine/curl without a tag found or pin found. Aborting! Fix this chart. not compatible with offline. Components need explicit tags for that
In the tests, we are currently using alpine/curl image without a tag, that is creating the issue. This pr fixes this by adding a tag to alpine/curl image.