Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebench-denoise restore is not done between build commands #249

Open
smarr opened this issue Aug 14, 2024 · 0 comments
Open

rebench-denoise restore is not done between build commands #249

smarr opened this issue Aug 14, 2024 · 0 comments
Labels
Bug help-wanted We'd like help with this issue, and are happy to provide guidance

Comments

@smarr
Copy link
Owner

smarr commented Aug 14, 2024

Without the restore, the system resources are severely restricted which dramatically increase build times etc.

The issue is likely something like this:

  1. build command execute
  2. benchmark started, for it, denoise is used
  3. then we do not do restore to not have to do it every time
  4. then we build another thing but are very restricted

So, I think, to keep avoiding minimizing/restoring settings all the time, we'd want to at least restore things before a build, and then minimize it when next needed.

This should also consider this issue: #168

@smarr smarr added Bug help-wanted We'd like help with this issue, and are happy to provide guidance labels Aug 14, 2024
@smarr smarr changed the title rebench-denoise restore is not done in all situation, likely when failure occur rebench-denoise restore is not done between build commands Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug help-wanted We'd like help with this issue, and are happy to provide guidance
Projects
None yet
Development

No branches or pull requests

1 participant