Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract Re-verification Does Not Perform Any Validation #1

Open
modenero opened this issue May 1, 2022 · 0 comments
Open

Contract Re-verification Does Not Perform Any Validation #1

modenero opened this issue May 1, 2022 · 0 comments

Comments

@modenero
Copy link

modenero commented May 1, 2022

The current implementation of this service stores the contract details to a local level database, upon validation "success".

However, when a user submits a re-verification, the service will return " success" no matter what parameters are provided by the user.

I don't think this is the intended purpose.

Instead, imo the stored level data should be used to compare the newly provided user params, which would avoid having to recompile the contract and spare much of the server's resources.


Please Note: I'm very happy to implement this change, however, I'm currently unable to run the backend locally. When I attempt to run the backend, it fails here:

let [deployedCode, errMsg] = await runCommand("./deploycode", [], creationBytecode.substr(2));

I'm missing the deploycode file.

I know it should be there, because it's mentioned in the .gitignore, but it's not included in the repo. How can I generate (or download) deploycode and fully enable my local implementation?

Thanks,
Shomari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant