Post review fixes

smartcontractkit · Mar 20, 2024 · 805eb06 · 805eb06
1 parent 3f42844
commit 805eb06
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/config/docs/chains-evm.toml b/core/config/docs/chains-evm.toml
@@ -52,11 +52,11 @@ LogBackfillBatchSize = 1000 # Default
 # LogPollInterval works in conjunction with Feature.LogPoller. Controls how frequently the log poller polls for logs. Defaults to the block production rate.
 LogPollInterval = '15s' # Default
 # **ADVANCED**
-# LogKeepBlocksDepth works in conjunction with Feature.LogPoller. Controls how many blocks the poller will keep, must be greater than FinalityDepth+1.
+# LogKeepBlocksDepth works in conjunction with Feature.LogPoller. Controls how many blocks the poller will keep, must be greater than FinalityDepth+1.[
 LogKeepBlocksDepth = 100000 # Default
 # **ADVANCED**
 # LogPrunePageSize defines size of the page for pruning logs. Controls how many logs/blocks (at most) are deleted in a single prune tick. Default value 0 means no paging, delete everything at once.
-LogPrunePageSize = 10000 # Default
+LogPrunePageSize = 10000 # CCIP uses paging when removing logs to avoid pushing too much presssure on the database
 # **ADVANCED**
 # BackupLogPollerBlockDelay works in conjunction with Feature.LogPoller. Controls the block delay of Backup LogPoller, affecting how far behind the latest finalized block it starts and how often it runs.
 # BackupLogPollerDelay=0 will disable Backup LogPoller (_not recommended for production environment_).

diff --git a/docs/CHANGELOG_CCIP.md b/docs/CHANGELOG_CCIP.md
@@ -14,7 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `OffRamp` offchain config changed:
   - `MaxGasPrice` and `DestMaxGasPrice` will be ignored if specified. DestMaxGasPrice will be read from PriceMax in chain TOML.
 - All LogPoller's filters have now retention defined. This means that the LogPoller will remove logs older than the retention defined per filter. 
-  Additionally, logs are now removed from the database in batches, defined by `LogPrunePageSize` in the toml config
+  Additionally, logs are now removed from the database in batches, defined by `LogPrunePageSize` in the toml config. Default value for all chains is 10_000.
 
 ## 1.4.0 - 2024-02-16