golangci-lint: enable early-return; fix one case (#424)

smartcontractkit · Mar 24, 2024 · 6182f8c · 6182f8c
1 parent 3f99346
commit 6182f8c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -73,7 +73,7 @@ linters-settings:
       - name: identical-branches
       - name: get-return
       # - name: flag-parameter
-      # - name: early-return
+      - name: early-return
       - name: defer
       - name: constant-logical-expr
       # - name: confusing-naming

diff --git a/pkg/capabilities/triggers/mercury_trigger.go b/pkg/capabilities/triggers/mercury_trigger.go
@@ -86,11 +86,10 @@ func (o *MercuryTriggerService) ProcessReport(reports []mercury.FeedReport) erro
 		}
 
 		ch, ok := o.chans[triggerID]
-		if ok {
-			ch <- capabilityResponse
-		} else {
+		if !ok {
 			return fmt.Errorf("no registration for %s", triggerID)
 		}
+		ch <- capabilityResponse
 	}
 	return nil
 }