Multisig wrapper #116
Closed
Multisig wrapper #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reductionista Opened the PR with the current working branch. Please rebase it with latest develop |
call() now calls prepareCall(), which creates and signs the tx, followed by broadcast() Similarly: deploy() calls prepareDeploy(), then broadcasts upload() calls prepareUpload(), then broadcasts
Also: fix compiler errors, workaround for gauntlet-core bug in type declaration for findPolymorphic
reductionista
force-pushed
the
multisig_wrapper
branch
from
3f8b33e to
f97ec19
Compare
reductionista
force-pushed
the
multisig_wrapper
branch
from
1413ecb to
f7891ab
Compare
RodrigoAD
commented
Feb 16, 2022
| } | ||
| } | ||
|
|
||
| type ICommandConstructor = (flags: any, args: string[]) => void |
There was a problem hiding this comment.
Why this "polymorphic" command? Why do we need it? We are already wrapping the commands into a multisig command
| } | ||
| } | ||
|
|
||
| // This is a temporary workaround for a bug in the type specification for findPolymorphic in @gauntlet-core. |
There was a problem hiding this comment.
Polymorphic is a legacy command that gauntlet-core had to support for old Gauntlet EVM, but we won't be using it in the future
| // For now, propose, vote, and execute functionality are all combined into one CONTRACT:COMMAND::multisig meta-command | ||
| // This is parallel to how things are implemented in Solana. The execute happens automatically as soon as the last | ||
| // vote required to exceeed the threshold is cast. And the difference between propose and vote is distinguished by | ||
| // whether the --proposal=PROPOSAL_HASH flag is passed. Later, we may want to split this into CONTRACT::COMMAND::propose, |
There was a problem hiding this comment.
We want to stick to the same process as EVM and Solana, where the multisig command tells us which step we are based on the proposal state
|
Closing in favor of: #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.