Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCI-1259: [REVISED] upgrade test #262

Closed
wants to merge 2 commits into from

Conversation

augustbleeds
Copy link
Collaborator

@augustbleeds augustbleeds commented May 11, 2023

Based off of #256 but git history got messy

@augustbleeds augustbleeds changed the base branch from develop to cairo-1.0 May 11, 2023 13:44
@augustbleeds augustbleeds changed the title Augustus.bci 1259.upgrade test BCI-1259: [REVISED] upgrade test May 11, 2023
@@ -4,6 +4,7 @@
"description": "",
"main": "index.js",
"scripts": {
"compile:cairo": "scarb --profile release build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, fyi the build contract actions in the Makefile were renamed to build-cairo-contracts and build-sol-contracts for clarity

@augustbleeds augustbleeds temporarily deployed to integration May 12, 2023 14:13 — with GitHub Actions Inactive
Base automatically changed from cairo-1.0 to develop May 16, 2023 08:07
@archseer
Copy link
Collaborator

archseer commented Jun 9, 2023

What's still left here? Tests might pass after a rebase

@augustbleeds augustbleeds deleted the augustus.BCI-1259.upgrade-test branch September 11, 2023 15:48
@augustbleeds augustbleeds restored the augustus.BCI-1259.upgrade-test branch September 11, 2023 15:48
@augustbleeds augustbleeds reopened this Sep 11, 2023
@augustbleeds augustbleeds force-pushed the augustus.BCI-1259.upgrade-test branch from df5df51 to ac3de33 Compare September 19, 2023 03:04
@augustbleeds augustbleeds temporarily deployed to integration September 19, 2023 03:04 — with GitHub Actions Inactive
@augustbleeds augustbleeds temporarily deployed to integration September 19, 2023 03:05 — with GitHub Actions Inactive
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@archseer
Copy link
Collaborator

Looks obsolete by now

@archseer archseer closed this Feb 27, 2024
@archseer archseer deleted the augustus.BCI-1259.upgrade-test branch February 27, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants