[TT-1921] fix breaking changes detection #1529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.23.3
in order to avoid errors like this:breakingchange
tool smarter, so it understands retracted tags.go mod tidy
in all projects.Sample output for
lib
after my changes:Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes across various
.yaml
,.go
, and.mod
files mainly revolve around updating Go version dependencies and refactoring the approach to identifying and handling retracted tags and breaking changes in Go modules. These updates ensure compatibility with newer Go versions and improve the accuracy of detecting breaking changes by accounting for retracted versions.What
.github/workflows/rc-breaking-changes.yaml & .github/workflows/release-go-module.yml
1.22.6
to1.23.3
to keep up with the latest Go releases for better features and security.tools/breakingchanges/cmd/main.go
getRetractedTags
function to identify retracted tags ingo.mod
files, improving the handling of module versions in the breaking changes detection process.getLastTag
togetLatestTag
and updated its logic to filter out retracted tags, ensuring the most recent and valid tag is used for comparison.semver
to accurately determine the latest version.isIgnoredDirPrefix
toisIgnoredDirRegex
, enhancing flexibility in specifying directories to ignore during the scan for breaking changes.sort
,github.com/Masterminds/semver/v3
,golang.org/x/mod/modfile
) to support new functionality related to semantic versioning and module file parsing.tools/breakingchanges/go.mod & tools/breakingchanges/go.sum
1.23.3
and added new module dependencies (github.com/Masterminds/semver/v3
,golang.org/x/mod
) required for the updated breaking changes detection logic.retract
directives for specific test versions, demonstrating the use of the retract feature in Go modules for managing incorrect or problematic releases.wasp/examples/go.mod & wasp/examples/go.sum
github.com/c9s/goprocinfo
,github.com/pbnjay/memory
), likely as part of dependency cleanup to remove unnecessary modules.wasp/go.mod & wasp/go.sum
wasp/examples
, removedgithub.com/c9s/goprocinfo
andgithub.com/pbnjay/memory
from the dependencies, indicating a cleanup process.