Fix PortMappings #1536
Merged
Fix PortMappings #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
smickovskid
temporarily deployed
to
integration
GitHub Actions
Inactive
archseer
force-pushed
the
docker_patches
branch
from
4e13e2e to
2e9ee3e
Compare
archseer
force-pushed
the
docker_patches
branch
from
2e9ee3e to
71d82b8
Compare
archseer
force-pushed
the
docker_patches
branch
from
71d82b8 to
b8ec05b
Compare
archseer
force-pushed
the
docker_patches
branch
from
b8ec05b to
a665d07
Compare
smickovskid
approved these changes
Jan 10, 2025
|
graham-chainlink
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mapping
8080/tcpto8080/tcp, which is technically invalid syntax but docker accepted it. We should map8080/tcpto8080(no protocol specifier). This fixes running CTF with podman.The second change is exposing the testcontainer object from the solana component. We're programatically using it within a test environment without a TOML config and would like to be able to call
testcontainers.CleanupContainer(c)