[ship-3971] Poll for headers when using http rpc #1537
Conversation
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
|
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
| go func() { | ||
| defer e.subscriptionWg.Done() | ||
| // Initialize lastHeaderNumber dynamically | ||
| lastHeaderNumber := latestHeader.Number.Uint64() - 1 |
There was a problem hiding this comment.
why -1? in the first run we could could just execute e.receiveHeader(latestHeader) after fetching last header.
won't doing -1 always result in the latest block being fetched 2x in every subsequent run?
| e.l.Error().Err(err).Uint64("BlockNumber", blockNum).Msg("Error fetching header during range processing") | ||
| continue | ||
| } | ||
| lastHeaderNumber = header.Number.Uint64() |
There was a problem hiding this comment.
why do we need it? maybe to be safe we could run lastHeaderNumber = latestHeader.Number.Uint64() after the for loop? like in my comment above
|
|
||
| // Process headers from (lastHeaderNumber + 1) to latestHeader.Number | ||
| // We may need to add a rate limiter, if we run into issues. | ||
| for blockNum := lastHeaderNumber + 1; blockNum <= latestHeader.Number.Uint64(); blockNum++ { |
There was a problem hiding this comment.
will that work? in :1292 you have set lastHeaderNumber to latestHeader and here you are iterating from latestHeader+1 to latestHeader, so this for loop shouldn't run even once...
maybe better just iterate like this:
blocksToFetch := latestHeader.Number.Uint64() - lastHeaderNumber
for blockNum := 0; blockNum < blocksToFetch; blockNum++ {
header, err := e.HeaderByNumber(context.Background(), big.NewInt(int64(blockNum)))
if err != nil {
e.l.Error().Err(err).Uint64("BlockNumber", blockNum).Msg("Error fetching header during range processing")
continue
}
if err := e.receiveHeader(header); err != nil {
e.l.Error().Err(err).Uint64("BlockNumber", blockNum).Msg("Error processing header")
continue
}
}
lastHeaderNumber = latestHeader.Number.Uint64()
I would also use < as condition, because the last block would have already been fetched and added in lines :1293-1295?
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce polling for headers as an alternative to subscription-based updates in environments where subscriptions are not supported, such as over HTTP. This ensures that the
EVMClientfunctionality remains robust across different network configurations and client capabilities.What
EVMClientto poll for headers when set up with an HTTP RPC.InitializeHeaderSubscriptionmethod in theEVMClientinterface to abstract the initialization of header updates, whether by subscription or polling.newEVMClientto initialize header subscription or polling depending on the client's capabilities.WaitForFinalizedTxto start polling for new headers if subscriptions are not supported.InitializeHeaderSubscriptionto decide between subscribing to new headers or starting a polling loop based on client support.startPollingHeadersmethod to begin polling for new headers at regular intervals if subscriptions are not supported.InitializeHeaderSubscriptionto initialize header subscription or polling for multinode clients.