perf tool enhancement

[Tofel]

Direct query comparison:

• add threshold validation,
• nil report validation,
• better readability for infinite metric change (999% instead of 100% since in reality the change is infinite)
• couple more unit tests for edge cases

---

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes refine the calculation of percentage differences, especially for edge cases where previous values are zero, and enhance the validation and comparison logic in the benchmark spy reporting functionality. This includes handling cases with nil reports, incorrect thresholds, and transitions from zero to non-zero values more gracefully, which improves the accuracy and reliability of performance comparison over time.

What

• wasp/benchspy/report.go
  • Modified calculateDiffPercentage function to handle edge cases, especially when the previous value is 0, by introducing conventions for infinite changes and complete improvements.
  • Added checks in CompareDirectWithThresholds to immediately return errors if one or both reports are nil, ensuring the function handles uninitialized reports.
  • Introduced validateThresholds function to ensure that the thresholds for median, P95, max latency, and error rate are within the acceptable range of 0 to 100.
• wasp/benchspy/report_test.go
  • Enhanced test cases to cover new scenarios, including handling of nil reports, incorrect threshold values, zero to non-zero transitions, and non-zero to zero transitions. This ensures the new logic behaves as expected under a wide range of conditions.

[Tofel]

code duplication content is related to unit tests, not gonna fix it 🤷

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
61.6% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube