fix(solana): fix broken smoke test #1547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoke test was expecting the mcm.so file due to the config in
blockchain_a.solana_programs
, since we dont provide any program to deploy in the smoke test, we should not define that config.I have also updated the default port for solana to be 8999 as that is the default port for solana test validator and it is what users would expect.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes update Solana configurations and defaults to improve the framework's compatibility and flexibility with different environments and use cases.
What
8545
to8999
. This modification ensures the port setting aligns better with Solana's default configurations.blockchain_a.solana_programs
section, simplifying the configuration by relying on defaults or external settings for Solana programs.