Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(solana): fix broken smoke test #1547

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Jan 10, 2025

The smoke test was expecting the mcm.so file due to the config in blockchain_a.solana_programs , since we dont provide any program to deploy in the smoke test, we should not define that config.

I have also updated the default port for solana to be 8999 as that is the default port for solana test validator and it is what users would expect.


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes update Solana configurations and defaults to improve the framework's compatibility and flexibility with different environments and use cases.

What

  • framework/components/blockchain/solana.go
    • Changed default port for Solana from 8545 to 8999. This modification ensures the port setting aligns better with Solana's default configurations.
  • framework/examples/myproject/smoke_solana.toml
    • Removed explicit Solana image version, allowing the framework to decide the best version dynamically, which is particularly beneficial for CI environments.
    • Removed blockchain_a.solana_programs section, simplifying the configuration by relying on defaults or external settings for Solana programs.

The smoke test was expecting the mcm.so file due to the config in `blockchain_a.solana_programs` , since we dont provide any program to deploy in the smoke test, we should not define that config.

I have also updated the default port for solana to be 8999 as that is the default port for solana test validator and it is what users would expect.
@cl-sonarqube-production
Copy link

@archseer archseer merged commit d70db91 into main Jan 10, 2025
54 of 55 checks passed
@archseer archseer deleted the ggoh/fix/broken-solana-smoke-test branch January 10, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants