From 0917394a4625c3e97b17e348dd473199a15402bf Mon Sep 17 00:00:00 2001 From: Finley Decker Date: Wed, 15 May 2024 11:30:33 -1000 Subject: [PATCH] update bumpThresholds for chains using suggestedPrice estimator (#13078) * update bumpThresholds for chains using suggestedPrice estimator * added changeset * added changeset * added tag to changeset * updated config docs --------- Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com> --- .changeset/silver-birds-wave.md | 5 +++++ .../config/toml/defaults/Arbitrum_Goerli.toml | 3 +-- .../toml/defaults/Arbitrum_Mainnet.toml | 3 +-- .../toml/defaults/Arbitrum_Rinkeby.toml | 3 +-- .../toml/defaults/Arbitrum_Sepolia.toml | 3 +-- .../config/toml/defaults/Klaytn_Mainnet.toml | 2 +- .../config/toml/defaults/Klaytn_Testnet.toml | 2 +- .../config/toml/defaults/Metis_Mainnet.toml | 3 +-- .../config/toml/defaults/Metis_Rinkeby.toml | 2 +- .../config/toml/defaults/Metis_Sepolia.toml | 2 +- .../config/toml/defaults/Scroll_Mainnet.toml | 2 -- .../config/toml/defaults/Scroll_Sepolia.toml | 2 -- docs/CONFIG.md | 22 +++++++++---------- 13 files changed, 25 insertions(+), 29 deletions(-) create mode 100644 .changeset/silver-birds-wave.md diff --git a/.changeset/silver-birds-wave.md b/.changeset/silver-birds-wave.md new file mode 100644 index 00000000000..e5a98dcde20 --- /dev/null +++ b/.changeset/silver-birds-wave.md @@ -0,0 +1,5 @@ +--- +"chainlink": patch +--- + +bumpThreshold config setting for chains using suggestPrice estimator #updated diff --git a/core/chains/evm/config/toml/defaults/Arbitrum_Goerli.toml b/core/chains/evm/config/toml/defaults/Arbitrum_Goerli.toml index 598b571352d..42de6beb9ba 100644 --- a/core/chains/evm/config/toml/defaults/Arbitrum_Goerli.toml +++ b/core/chains/evm/config/toml/defaults/Arbitrum_Goerli.toml @@ -13,8 +13,7 @@ PriceMin = '0' PriceDefault = '0.1 gwei' PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether' FeeCapDefault = '1000 gwei' -# Disable gas bumping on arbitrum -BumpThreshold = 0 +BumpThreshold = 5 [GasEstimator.BlockHistory] # Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum diff --git a/core/chains/evm/config/toml/defaults/Arbitrum_Mainnet.toml b/core/chains/evm/config/toml/defaults/Arbitrum_Mainnet.toml index 350d15cfccb..b297db1bc0f 100644 --- a/core/chains/evm/config/toml/defaults/Arbitrum_Mainnet.toml +++ b/core/chains/evm/config/toml/defaults/Arbitrum_Mainnet.toml @@ -15,8 +15,7 @@ PriceMin = '0' PriceDefault = '0.1 gwei' PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether' FeeCapDefault = '1000 gwei' -# Disable gas bumping on arbitrum -BumpThreshold = 0 +BumpThreshold = 5 [GasEstimator.BlockHistory] # Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum diff --git a/core/chains/evm/config/toml/defaults/Arbitrum_Rinkeby.toml b/core/chains/evm/config/toml/defaults/Arbitrum_Rinkeby.toml index ef9a5408a53..f9296adcb76 100644 --- a/core/chains/evm/config/toml/defaults/Arbitrum_Rinkeby.toml +++ b/core/chains/evm/config/toml/defaults/Arbitrum_Rinkeby.toml @@ -13,8 +13,7 @@ PriceMin = '0' PriceDefault = '0.1 gwei' PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether' FeeCapDefault = '1000 gwei' -# Disable gas bumping on arbitrum -BumpThreshold = 0 +BumpThreshold = 5 [GasEstimator.BlockHistory] # Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum diff --git a/core/chains/evm/config/toml/defaults/Arbitrum_Sepolia.toml b/core/chains/evm/config/toml/defaults/Arbitrum_Sepolia.toml index e26a137d2ba..e6d660a2729 100644 --- a/core/chains/evm/config/toml/defaults/Arbitrum_Sepolia.toml +++ b/core/chains/evm/config/toml/defaults/Arbitrum_Sepolia.toml @@ -12,8 +12,7 @@ PriceMin = '0' PriceDefault = '0.1 gwei' PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether' FeeCapDefault = '1000 gwei' -# Disable gas bumping on arbitrum -BumpThreshold = 0 +BumpThreshold = 5 [GasEstimator.BlockHistory] # Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum diff --git a/core/chains/evm/config/toml/defaults/Klaytn_Mainnet.toml b/core/chains/evm/config/toml/defaults/Klaytn_Mainnet.toml index c68f03b0446..1994f309afc 100644 --- a/core/chains/evm/config/toml/defaults/Klaytn_Mainnet.toml +++ b/core/chains/evm/config/toml/defaults/Klaytn_Mainnet.toml @@ -7,4 +7,4 @@ OCR.ContractConfirmations = 1 [GasEstimator] Mode = 'SuggestedPrice' PriceDefault = '750 gwei' # gwei = ston -BumpThreshold = 0 +BumpThreshold = 5 diff --git a/core/chains/evm/config/toml/defaults/Klaytn_Testnet.toml b/core/chains/evm/config/toml/defaults/Klaytn_Testnet.toml index 864aa0fa72a..625afd649ea 100644 --- a/core/chains/evm/config/toml/defaults/Klaytn_Testnet.toml +++ b/core/chains/evm/config/toml/defaults/Klaytn_Testnet.toml @@ -7,4 +7,4 @@ OCR.ContractConfirmations = 1 [GasEstimator] Mode = 'SuggestedPrice' PriceDefault = '750 gwei' # gwei = ston -BumpThreshold = 0 +BumpThreshold = 5 diff --git a/core/chains/evm/config/toml/defaults/Metis_Mainnet.toml b/core/chains/evm/config/toml/defaults/Metis_Mainnet.toml index 3e8efa531cc..337138d565e 100644 --- a/core/chains/evm/config/toml/defaults/Metis_Mainnet.toml +++ b/core/chains/evm/config/toml/defaults/Metis_Mainnet.toml @@ -11,8 +11,7 @@ OCR.ContractConfirmations = 1 Mode = 'SuggestedPrice' # Metis uses the SuggestedPrice estimator; we don't want to place any limits on the minimum gas price PriceMin = '0' -# Never bump gas on metis -BumpThreshold = 0 +BumpThreshold = 3 [BalanceMonitor] Enabled = true diff --git a/core/chains/evm/config/toml/defaults/Metis_Rinkeby.toml b/core/chains/evm/config/toml/defaults/Metis_Rinkeby.toml index 7d9fec9076f..5dccf3719b9 100644 --- a/core/chains/evm/config/toml/defaults/Metis_Rinkeby.toml +++ b/core/chains/evm/config/toml/defaults/Metis_Rinkeby.toml @@ -11,7 +11,7 @@ Enabled = true [GasEstimator] Mode = 'SuggestedPrice' PriceMin = '0' -BumpThreshold = 0 +BumpThreshold = 3 [GasEstimator.BlockHistory] BlockHistorySize = 0 diff --git a/core/chains/evm/config/toml/defaults/Metis_Sepolia.toml b/core/chains/evm/config/toml/defaults/Metis_Sepolia.toml index 2391ee2cab3..d8ddffd77d7 100644 --- a/core/chains/evm/config/toml/defaults/Metis_Sepolia.toml +++ b/core/chains/evm/config/toml/defaults/Metis_Sepolia.toml @@ -11,7 +11,7 @@ Enabled = true [GasEstimator] Mode = 'SuggestedPrice' PriceMin = '0' -BumpThreshold = 0 +BumpThreshold = 3 [GasEstimator.BlockHistory] BlockHistorySize = 0 diff --git a/core/chains/evm/config/toml/defaults/Scroll_Mainnet.toml b/core/chains/evm/config/toml/defaults/Scroll_Mainnet.toml index e087b86fe3e..21d4699ee8a 100644 --- a/core/chains/evm/config/toml/defaults/Scroll_Mainnet.toml +++ b/core/chains/evm/config/toml/defaults/Scroll_Mainnet.toml @@ -11,8 +11,6 @@ OCR.ContractConfirmations = 1 Mode = 'SuggestedPrice' # Scroll uses the SuggestedPrice estimator; we don't want to place any limits on the minimum gas price PriceMin = '0' -# Never bump gas on Scroll -BumpThreshold = 0 [GasEstimator.BlockHistory] # Force an error if someone enables the estimator by accident; we never want to run the block history estimator on Scroll diff --git a/core/chains/evm/config/toml/defaults/Scroll_Sepolia.toml b/core/chains/evm/config/toml/defaults/Scroll_Sepolia.toml index 9db7a8ebed5..27ac984865d 100644 --- a/core/chains/evm/config/toml/defaults/Scroll_Sepolia.toml +++ b/core/chains/evm/config/toml/defaults/Scroll_Sepolia.toml @@ -11,8 +11,6 @@ OCR.ContractConfirmations = 1 Mode = 'SuggestedPrice' # Scroll uses the SuggestedPrice estimator; we don't want to place any limits on the minimum gas price PriceMin = '0' -# Never bump gas on Scroll -BumpThreshold = 0 [GasEstimator.BlockHistory] # Force an error if someone enables the estimator by accident; we never want to run the block history estimator on Scroll diff --git a/docs/CONFIG.md b/docs/CONFIG.md index 61ba9256d9d..a0e2957cd72 100644 --- a/docs/CONFIG.md +++ b/docs/CONFIG.md @@ -3729,7 +3729,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 3 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei' @@ -3813,7 +3813,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 5 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei' @@ -3898,7 +3898,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 3 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei' @@ -4658,7 +4658,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 5 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei' @@ -4914,7 +4914,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 5 EIP1559DynamicFees = false FeeCapDefault = '1 micro' TipCapDefault = '1 wei' @@ -5591,7 +5591,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 3 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei' @@ -6016,7 +6016,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 5 EIP1559DynamicFees = false FeeCapDefault = '1 micro' TipCapDefault = '1 wei' @@ -6102,7 +6102,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 5 EIP1559DynamicFees = false FeeCapDefault = '1 micro' TipCapDefault = '1 wei' @@ -6187,7 +6187,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 5 EIP1559DynamicFees = false FeeCapDefault = '1 micro' TipCapDefault = '1 wei' @@ -6272,7 +6272,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 3 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei' @@ -6357,7 +6357,7 @@ LimitMultiplier = '1' LimitTransfer = 21000 BumpMin = '5 gwei' BumpPercent = 20 -BumpThreshold = 0 +BumpThreshold = 3 EIP1559DynamicFees = false FeeCapDefault = '100 gwei' TipCapDefault = '1 wei'