From 2d40de4408f651f87ade1a33571e05cdbf0807f8 Mon Sep 17 00:00:00 2001 From: krehermann Date: Mon, 11 Sep 2023 14:12:36 -0600 Subject: [PATCH] delete unused code (#10588) --- core/chains/chain_kv.go | 1 - core/chains/chain_kv_test.go | 8 +----- .../chainlink/relayer_chain_interoperators.go | 1 - core/services/relay/evm/relayer_extender.go | 28 ------------------- .../relay/evm/relayer_extender_test.go | 11 -------- 5 files changed, 1 insertion(+), 48 deletions(-) diff --git a/core/chains/chain_kv.go b/core/chains/chain_kv.go index 6224be1c5c3..5094f2885e5 100644 --- a/core/chains/chain_kv.go +++ b/core/chains/chain_kv.go @@ -17,7 +17,6 @@ type ChainsKV[T types.ChainService] struct { var ErrNoSuchChainID = errors.New("chain id does not exist") func NewChainsKV[T types.ChainService](cs map[string]T) *ChainsKV[T] { - return &ChainsKV[T]{ chains: cs, } diff --git a/core/chains/chain_kv_test.go b/core/chains/chain_kv_test.go index f226b6f38be..a30de3090b8 100644 --- a/core/chains/chain_kv_test.go +++ b/core/chains/chain_kv_test.go @@ -89,19 +89,13 @@ func (s *testChainService) HealthReport() map[string]error { return map[string]error{} } -// Implement updated [loop.Relay] interface funcs in preparation for BCF-2441 -// TODO update this comment after BCF-2441 is done +// Implement [types.ChainService] interface func (s *testChainService) GetChainStatus(ctx context.Context) (stat types.ChainStatus, err error) { return } func (s *testChainService) ListNodeStatuses(ctx context.Context, pageSize int32, pageToken string) (stats []types.NodeStatus, nextPageToken string, total int, err error) { return } - func (s *testChainService) Transact(ctx context.Context, from string, to string, amount *big.Int, balanceCheck bool) error { return nil } - -func (s *testChainService) SendTx(ctx context.Context, from string, to string, amount *big.Int, balanceCheck bool) error { - return nil -} diff --git a/core/services/chainlink/relayer_chain_interoperators.go b/core/services/chainlink/relayer_chain_interoperators.go index 8a0b2ad001f..823d3f88c98 100644 --- a/core/services/chainlink/relayer_chain_interoperators.go +++ b/core/services/chainlink/relayer_chain_interoperators.go @@ -276,7 +276,6 @@ func (rs *CoreRelayerChainInteroperators) Node(ctx context.Context, name string) // ids must be a string representation of relay.Identifier // ids are a filter; if none are specified, all are returned. -// TODO: BCF-2440/1 this signature can be changed to id relay.Identifier which is a much better API func (rs *CoreRelayerChainInteroperators) NodeStatuses(ctx context.Context, offset, limit int, relayerIDs ...relay.ID) (nodes []types.NodeStatus, count int, err error) { var ( totalErr error diff --git a/core/services/relay/evm/relayer_extender.go b/core/services/relay/evm/relayer_extender.go index c71ccd03b25..9f19ef13143 100644 --- a/core/services/relay/evm/relayer_extender.go +++ b/core/services/relay/evm/relayer_extender.go @@ -23,8 +23,6 @@ type EVMChainRelayerExtender interface { relay.RelayerExt Chain() evmchain.Chain Default() bool - // compatibility remove after BCF-2441 - NodeStatuses(ctx context.Context, offset, limit int, chainIDs ...string) (nodes []relaytypes.NodeStatus, count int, err error) } type EVMChainRelayerExtenderSlicer interface { @@ -133,32 +131,6 @@ func (s *ChainRelayerExt) Ready() (err error) { return s.chain.Ready() } -var ErrInconsistentChainRelayerExtender = errors.New("inconsistent evm chain relayer extender") - -func (s *ChainRelayerExt) NodeStatuses(ctx context.Context, offset, limit int, chainIDs ...string) (nodes []relaytypes.NodeStatus, total int, err error) { - if len(chainIDs) > 1 { - return nil, -1, fmt.Errorf("single chain chain set only support one chain id. got %v", chainIDs) - } - cid := chainIDs[0] - if cid != s.chain.ID().String() { - return nil, -1, fmt.Errorf("unknown chain id %s. expected %s", cid, s.chain.ID()) - } - nodes, _, total, err = s.ListNodeStatuses(ctx, int32(limit), "") - if err != nil { - return nil, -1, err - } - if len(nodes) < offset { - return []relaytypes.NodeStatus{}, -1, fmt.Errorf("out of range") - } - if limit <= 0 { - limit = len(nodes) - } else if len(nodes) < limit { - limit = len(nodes) - } - return nodes[offset:limit], total, nil - -} - func NewChainRelayerExtenders(ctx context.Context, opts evmchain.ChainRelayExtenderConfig) (*ChainRelayerExtenders, error) { if err := opts.Check(); err != nil { return nil, err diff --git a/core/services/relay/evm/relayer_extender_test.go b/core/services/relay/evm/relayer_extender_test.go index 6caf8472478..361a7468f30 100644 --- a/core/services/relay/evm/relayer_extender_test.go +++ b/core/services/relay/evm/relayer_extender_test.go @@ -66,15 +66,4 @@ func TestChainRelayExtenders(t *testing.T) { assert.NotEmpty(t, s) assert.NoError(t, err) - // test error conditions for NodeStatuses - nstats, cnt, err := relayExt.NodeStatuses(testutils.Context(t), 0, 0, cltest.FixtureChainID.String(), "error, only one chain supported") - assert.Error(t, err) - assert.Nil(t, nstats) - assert.Equal(t, -1, cnt) - - nstats, cnt, err = relayExt.NodeStatuses(testutils.Context(t), 0, 0, "not the chain id") - assert.Error(t, err) - assert.Nil(t, nstats) - assert.Equal(t, -1, cnt) - }