remove error check which skips batching retries [BCI-3359](https://sm…

…artcontract-it.atlassian.net/browse/BCI-3359) (#13671) * remove error check which skips batching retries * fix typo in changeset
smartcontractkit · Jun 24, 2024 · 4493b96 · 4493b96
1 parent fc3a291
commit 4493b96
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.changeset/tiny-camels-flow.md b/.changeset/tiny-camels-flow.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#bugfix fixed ureachable code bug which could result in stuck txns
diff --git a/core/chains/evm/logpoller/orm.go b/core/chains/evm/logpoller/orm.go
@@ -394,9 +394,6 @@ func (o *DSORM) insertLogsWithinTx(ctx context.Context, logs []Log, tx sqlutil.D
 				ON CONFLICT DO NOTHING`
 
 		_, err := o.ds.NamedExecContext(ctx, query, logs[start:end])
-		if err != nil {
-			return err
-		}
 		if err != nil {
 			if pkgerrors.Is(err, context.DeadlineExceeded) && batchInsertSize > 500 {
 				// In case of DB timeouts, try to insert again with a smaller batch upto a limit