From 4493b96f62d18376d89ae152cb0df3eab87ab5fd Mon Sep 17 00:00:00 2001 From: Jim W Date: Mon, 24 Jun 2024 13:05:51 -0400 Subject: [PATCH] remove error check which skips batching retries [BCI-3359](https://smartcontract-it.atlassian.net/browse/BCI-3359) (#13671) * remove error check which skips batching retries * fix typo in changeset --- .changeset/tiny-camels-flow.md | 5 +++++ core/chains/evm/logpoller/orm.go | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 .changeset/tiny-camels-flow.md diff --git a/.changeset/tiny-camels-flow.md b/.changeset/tiny-camels-flow.md new file mode 100644 index 00000000000..3271bbb4a39 --- /dev/null +++ b/.changeset/tiny-camels-flow.md @@ -0,0 +1,5 @@ +--- +"chainlink": patch +--- + +#bugfix fixed ureachable code bug which could result in stuck txns diff --git a/core/chains/evm/logpoller/orm.go b/core/chains/evm/logpoller/orm.go index b9a1ca39f4a..1d249760736 100644 --- a/core/chains/evm/logpoller/orm.go +++ b/core/chains/evm/logpoller/orm.go @@ -394,9 +394,6 @@ func (o *DSORM) insertLogsWithinTx(ctx context.Context, logs []Log, tx sqlutil.D ON CONFLICT DO NOTHING` _, err := o.ds.NamedExecContext(ctx, query, logs[start:end]) - if err != nil { - return err - } if err != nil { if pkgerrors.Is(err, context.DeadlineExceeded) && batchInsertSize > 500 { // In case of DB timeouts, try to insert again with a smaller batch upto a limit