From 6bf25fc01c2e0c7de2ef9d79d511688c276368c1 Mon Sep 17 00:00:00 2001 From: Juan Farber Date: Tue, 16 Jul 2024 06:05:26 -0300 Subject: [PATCH] [BCI-3837] - Remove tautological check inside EVM TXM (#13857) * remove tautological err check * add changeset --- .changeset/dull-seals-jog.md | 5 +++++ core/chains/evm/txmgr/evm_tx_store.go | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 .changeset/dull-seals-jog.md diff --git a/.changeset/dull-seals-jog.md b/.changeset/dull-seals-jog.md new file mode 100644 index 00000000000..12dbb06d86d --- /dev/null +++ b/.changeset/dull-seals-jog.md @@ -0,0 +1,5 @@ +--- +"chainlink": patch +--- + +remove tautological err check within evm txm. #internal diff --git a/core/chains/evm/txmgr/evm_tx_store.go b/core/chains/evm/txmgr/evm_tx_store.go index 4474688b47c..e83a83907e4 100644 --- a/core/chains/evm/txmgr/evm_tx_store.go +++ b/core/chains/evm/txmgr/evm_tx_store.go @@ -1704,9 +1704,7 @@ func (o *evmTxStore) UpdateTxUnstartedToInProgress(ctx context.Context, etx *Tx, pqErr.ConstraintName == "eth_tx_attempts_eth_tx_id_fkey" { return txmgr.ErrTxRemoved } - if err != nil { - return pkgerrors.Wrap(err, "UpdateTxUnstartedToInProgress failed to create eth_tx_attempt") - } + return pkgerrors.Wrap(err, "UpdateTxUnstartedToInProgress failed to create eth_tx_attempt") } dbAttempt.ToTxAttempt(attempt) var dbEtx DbEthTx