From 9a0fd345a3679596413381f7a8d29e8f5f022a7e Mon Sep 17 00:00:00 2001 From: Patrick Date: Tue, 29 Oct 2024 13:32:45 -0400 Subject: [PATCH] removing workflow execution id label from engine metrics (#14997) --- core/services/workflows/engine.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/services/workflows/engine.go b/core/services/workflows/engine.go index 7bff029a60a..a814b6a9007 100644 --- a/core/services/workflows/engine.go +++ b/core/services/workflows/engine.go @@ -433,7 +433,7 @@ func (e *Engine) registerTrigger(ctx context.Context, t *triggerCapability, trig } eventsCh, err := t.trigger.RegisterTrigger(ctx, triggerRegRequest) if err != nil { - e.metrics.with(cIDKey, t.ID, tIDKey, triggerID).incrementRegisterTriggerFailureCounter(ctx) + e.metrics.incrementRegisterTriggerFailureCounter(ctx) // It's confusing that t.ID is different from triggerID, but // t.ID is the capability ID, and triggerID is the trigger ID. // @@ -661,7 +661,7 @@ func (e *Engine) queueIfReady(state store.WorkflowExecution, step *step) { func (e *Engine) finishExecution(ctx context.Context, executionID string, status string) error { e.logger.With(eIDKey, executionID, "status", status).Info("finishing execution") - metrics := e.metrics.with(eIDKey, executionID, "status", status) + metrics := e.metrics.with("status", status) err := e.executionStates.UpdateStatus(ctx, executionID, status) if err != nil { return err