From 9ed165108b1e516ada5142d7b412c7022d06d814 Mon Sep 17 00:00:00 2001 From: James Walker Date: Fri, 5 Jan 2024 16:39:02 -0500 Subject: [PATCH] cleanup --- common/txmgr/address_state.go | 3 --- common/txmgr/inmemory_store.go | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/common/txmgr/address_state.go b/common/txmgr/address_state.go index b299bb1f9fa..1ce8d21c43c 100644 --- a/common/txmgr/address_state.go +++ b/common/txmgr/address_state.go @@ -172,9 +172,6 @@ func NewAddressState[ } func (as *AddressState[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) close() { - as.Lock() - defer as.Unlock() - as.unstarted.Close() as.unstarted = nil as.inprogress = nil diff --git a/common/txmgr/inmemory_store.go b/common/txmgr/inmemory_store.go index 854f378e4c0..0433948e9fb 100644 --- a/common/txmgr/inmemory_store.go +++ b/common/txmgr/inmemory_store.go @@ -20,9 +20,9 @@ import ( ) // BIG TODO LIST -// TODO: make sure that all state transitions are handled by the address state to ensure that the in-memory store is always in a consistent state // TODO: figure out if multiple tx attempts are actually stored in the db for each tx // TODO: need a way to get id for a tx attempt. since there are some methods where the persistent store creates a tx attempt and doesnt returns it +// TODO: should txAttempt state transitions be handled by the address state manager? var ( // ErrInvalidChainID is returned when the chain ID is invalid