Skip to content

Commit

Permalink
improve error message when log config fails to unpack (#10353)
Browse files Browse the repository at this point in the history
* improve error message when log config fails to unpack

* update

* rm unrelated change
  • Loading branch information
infiloop2 authored Aug 25, 2023
1 parent dc83873 commit a2ff8c6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion core/services/ocr2/plugins/ocr2keeper/evm21/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,9 @@ func (r *EvmRegistry) updateTriggerConfig(id *big.Int, cfg []byte, logBlock uint
}
parsed, err := r.packer.UnpackLogTriggerConfig(cfg)
if err != nil {
return errors.Wrap(err, "failed to unpack log upkeep config")
// Upkeep has been setup with improper config. Log a warning and ignore the upkeep.
r.lggr.Warnw("failed to unpack log upkeep config", "upkeepID", id.String(), "err", err)
return nil
}
if err := r.logEventProvider.RegisterFilter(logprovider.FilterOptions{
TriggerConfig: logprovider.LogTriggerConfig(parsed),
Expand Down

0 comments on commit a2ff8c6

Please sign in to comment.