From d03afbbf9731a5ac272ded4dfbfe3f6b925af5c8 Mon Sep 17 00:00:00 2001 From: Ilja Pavlovs Date: Sat, 24 Feb 2024 02:34:46 +0200 Subject: [PATCH] VRF-881: fixing lint issues --- integration-tests/actions/vrf/vrfv2plus/vrfv2plus_steps.go | 3 +++ integration-tests/smoke/vrfv2plus_test.go | 6 +++--- integration-tests/testconfig/vrfv2/config.go | 2 +- integration-tests/testconfig/vrfv2plus/config.go | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/integration-tests/actions/vrf/vrfv2plus/vrfv2plus_steps.go b/integration-tests/actions/vrf/vrfv2plus/vrfv2plus_steps.go index 4250585a8fe..aaacb541c98 100644 --- a/integration-tests/actions/vrf/vrfv2plus/vrfv2plus_steps.go +++ b/integration-tests/actions/vrf/vrfv2plus/vrfv2plus_steps.go @@ -328,6 +328,9 @@ func SetupVRFV2PlusContracts( vrfContracts.CoordinatorV2Plus, vrfContracts.VRFV2PlusConsumer, numberOfSubToCreate, ) + if err != nil { + return nil, nil, err + } return vrfContracts, subIDs, nil } diff --git a/integration-tests/smoke/vrfv2plus_test.go b/integration-tests/smoke/vrfv2plus_test.go index 4a097bd2820..07360afcbeb 100644 --- a/integration-tests/smoke/vrfv2plus_test.go +++ b/integration-tests/smoke/vrfv2plus_test.go @@ -107,9 +107,9 @@ func TestVRFv2Plus(t *testing.T) { ) require.NoError(t, err, "error requesting randomness and waiting for fulfilment") - require.False(t, randomWordsFulfilledEvent.OnlyPremium) - require.Equal(t, isNativeBilling, randomWordsFulfilledEvent.NativePayment) - require.True(t, randomWordsFulfilledEvent.Success) + require.False(t, randomWordsFulfilledEvent.OnlyPremium, "RandomWordsFulfilled Event's `OnlyPremium` field should be false") + require.Equal(t, isNativeBilling, randomWordsFulfilledEvent.NativePayment, "RandomWordsFulfilled Event's `NativePayment` field should be false") + require.True(t, randomWordsFulfilledEvent.Success, "RandomWordsFulfilled Event's `Success` field should be true") expectedSubBalanceJuels := new(big.Int).Sub(subBalanceBeforeRequest, randomWordsFulfilledEvent.Payment) subscription, err = vrfv2PlusContracts.CoordinatorV2Plus.GetSubscription(testcontext.Get(t), subID) diff --git a/integration-tests/testconfig/vrfv2/config.go b/integration-tests/testconfig/vrfv2/config.go index d930a89f6c7..dcfd959880b 100644 --- a/integration-tests/testconfig/vrfv2/config.go +++ b/integration-tests/testconfig/vrfv2/config.go @@ -25,7 +25,7 @@ func (c *Config) Validate() error { return err } } - if c.ExistingEnvConfig != nil && *c.General.UseExistingEnv == true { + if c.ExistingEnvConfig != nil && *c.General.UseExistingEnv { if err := c.ExistingEnvConfig.Validate(); err != nil { return err } diff --git a/integration-tests/testconfig/vrfv2plus/config.go b/integration-tests/testconfig/vrfv2plus/config.go index 54a151a53c8..fe05dbd9d18 100644 --- a/integration-tests/testconfig/vrfv2plus/config.go +++ b/integration-tests/testconfig/vrfv2plus/config.go @@ -31,7 +31,7 @@ func (c *Config) Validate() error { return err } } - if c.ExistingEnvConfig != nil && *c.General.UseExistingEnv == true { + if c.ExistingEnvConfig != nil && *c.General.UseExistingEnv { if err := c.ExistingEnvConfig.Validate(); err != nil { return err }