From e42562cc435d6136925383e2368e99dbd1663a59 Mon Sep 17 00:00:00 2001 From: Rens Rooimans Date: Mon, 20 Nov 2023 14:26:13 +0100 Subject: [PATCH] fix solidity codeowners (#11300) --- CODEOWNERS | 33 ++++++++++++++++------- contracts/scripts/native_solc_compile_all | 2 +- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 5f33e68e514..bd2d0419cf7 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -73,23 +73,38 @@ core/scripts/gateway @bolekk @pinebit # Contracts /contracts/ @se3000 @connorwstein @RensR -/contracts/srv/v0.8/automation @smartcontractkit/keepers +# First we match on project names to catch files like the compilation scripts, +# gas snapshots and other files not places in the project directories. +# This could give some false positives, so afterwards we match on the project directories +# to ensure the entire directory is always owned by the correct team. + +/contracts/**/*shared* @RensR /contracts/**/*keeper* @smartcontractkit/keepers /contracts/**/*upkeep* @smartcontractkit/keepers /contracts/**/*automation* @smartcontractkit/keepers -/contracts/gas-snapshots/automation.gas-snapshot @smartcontractkit/keepers - -/contracts/src/v0.8/functions @smartcontractkit/functions /contracts/**/*functions* @smartcontractkit/functions -/contracts/gas-snapshots/functions.gas-snapshot @smartcontractkit/functions +/contracts/**/*llo-feeds* @austinborn @Fletch153 +/contracts/**/*vrf* @smartcontractkit/vrf-team +/contracts/**/*l2ep* @simsonraj +/contracts/**/*operatorforwarder* @essamhassan +/contracts/src/v0.8/automation @smartcontractkit/keepers +/contracts/src/v0.8/functions @smartcontractkit/functions +# TODO: interfaces folder, folder should be removed and files moved to the correct folders +/contracts/src/v0.8/l2ep @simsonraj /contracts/src/v0.8/llo-feeds @austinborn @Fletch153 -/contracts/gas-snapshots/llo-feeds.gas-snapshot @austinborn @Fletch153 - +# TODO: mocks folder, folder should be removed and files moved to the correct folders +/contracts/src/v0.8/operatorforwarder @essamhassan +/contracts/src/v0.8/shared @RensR +# TODO: tests folder, folder should be removed and files moved to the correct folders +# TODO: transmission folder, owner should be found /contracts/src/v0.8/vrf @smartcontractkit/vrf-team -/contracts/**/*vrf* @smartcontractkit/vrf-team -/contracts/src/v0.8/l2ep @simsonraj + + +# At the end, match any files missed by the patterns above +/contracts/scripts/native_solc_compile_all_events_mock @smartcontractkit/functions + # Tests /integration-tests/ @smartcontractkit/test-tooling-team diff --git a/contracts/scripts/native_solc_compile_all b/contracts/scripts/native_solc_compile_all index a2f2f1a0bc3..cf1226a2d5c 100755 --- a/contracts/scripts/native_solc_compile_all +++ b/contracts/scripts/native_solc_compile_all @@ -12,7 +12,7 @@ python3 -m pip install --require-hashes -r $SCRIPTPATH/requirements.txt # 6 and 7 are legacy contracts, for each other product we have a native_solc_compile_all_$product script # These scripts can be run individually, or all together with this script. # To add new CL products, simply write a native_solc_compile_all_$product script and add it to the list below. -for product in 6 7 feeds functions llo-feeds transmission vrf automation operatorforwarder logpoller events_mock shared +for product in 6 7 automation events_mock feeds functions llo-feeds logpoller operatorforwarder shared transmission vrf do $SCRIPTPATH/native_solc_compile_all_$product done