From e427abbf4baf54e39281ee83495352c2de0ff02d Mon Sep 17 00:00:00 2001
From: frank zhu <fr@nkzhu.com>
Date: Thu, 14 Dec 2023 06:41:44 -0800
Subject: [PATCH] add CI test for core/scripts (#11466)

* add CI test for core/scripts

* refactor

* refactor golangci-lint build binary step

* add ubig pkg

* refactor based on suggestions
---
 .github/actions/golangci-lint/action.yml |  7 +---
 .github/workflows/ci-chaincli.yml        | 22 ------------
 .github/workflows/ci-scripts.yml         | 46 ++++++++++++++++++++++++
 core/scripts/functions/src/fetching.go   |  1 +
 4 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 .github/workflows/ci-chaincli.yml
 create mode 100644 .github/workflows/ci-scripts.yml

diff --git a/.github/actions/golangci-lint/action.yml b/.github/actions/golangci-lint/action.yml
index 055960ff282..0047c6a54bd 100644
--- a/.github/actions/golangci-lint/action.yml
+++ b/.github/actions/golangci-lint/action.yml
@@ -42,14 +42,9 @@ runs:
       shell: bash
       run: mkdir -p core/web/assets && touch core/web/assets/index.html
     - name: Build binary
-      if: ${{ inputs.go-directory == '.' }}
-      shell: bash
-      run: go build ./...
-    - name: Build binary
-      if: ${{ inputs.go-directory != '.' }}
       working-directory: ${{ inputs.go-directory }}
       shell: bash
-      run: go build
+      run: go build ./...
     - name: golangci-lint
       uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
       with:
diff --git a/.github/workflows/ci-chaincli.yml b/.github/workflows/ci-chaincli.yml
deleted file mode 100644
index 8a9ab03d766..00000000000
--- a/.github/workflows/ci-chaincli.yml
+++ /dev/null
@@ -1,22 +0,0 @@
-name: chaincli CI
-
-on:
-  push:
-  pull_request:
-
-jobs:
-  golangci:
-    if: ${{ github.event_name == 'pull_request' ||  github.event_name == 'schedule' }}
-    name: chaincli-lint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-      - name: Golang Lint
-        uses: ./.github/actions/golangci-lint
-        with:
-          name: chaincli-lint
-          go-directory: core/scripts/chaincli
-          go-version-file: core/scripts/go.mod
-          go-module-file: core/scripts/go.sum
-          gc-basic-auth: ${{ secrets.GRAFANA_CLOUD_BASIC_AUTH }}
-          gc-host: ${{ secrets.GRAFANA_CLOUD_HOST }}
diff --git a/.github/workflows/ci-scripts.yml b/.github/workflows/ci-scripts.yml
new file mode 100644
index 00000000000..e83c22520cd
--- /dev/null
+++ b/.github/workflows/ci-scripts.yml
@@ -0,0 +1,46 @@
+name: CI Scripts
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  golangci:
+    if: ${{ github.event_name == 'pull_request' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - name: Golang Lint
+        uses: ./.github/actions/golangci-lint
+        with:
+          name: scripts-lint
+          go-directory: core/scripts
+          go-version-file: core/scripts/go.mod
+          go-module-file: core/scripts/go.sum
+          gc-basic-auth: ${{ secrets.GRAFANA_CLOUD_BASIC_AUTH }}
+          gc-host: ${{ secrets.GRAFANA_CLOUD_HOST }}
+
+  test:
+    if: ${{ github.event_name == 'pull_request' }}
+    name: scripts-test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 
+      - name: Setup Go
+        uses: ./.github/actions/setup-go
+        with:
+          go-version-file: core/scripts/go.mod
+          go-module-file: core/scripts/go.sum
+      - name: Run Tests
+        shell: bash
+        working-directory: core/scripts
+        run: go test ./...
+      - name: Collect Metrics
+        if: always()
+        id: collect-gha-metrics
+        uses: smartcontractkit/push-gha-metrics-action@d1618b772a97fd87e6505de97b872ee0b1f1729a # v2.0.2
+        with:
+          basic-auth: ${{ secrets.GRAFANA_CLOUD_BASIC_AUTH }}
+          hostname: ${{ secrets.GRAFANA_CLOUD_HOST }}
+          this-job-name: scripts-test
+        continue-on-error: true
diff --git a/core/scripts/functions/src/fetching.go b/core/scripts/functions/src/fetching.go
index 9be624a40b6..cbe491fff5e 100644
--- a/core/scripts/functions/src/fetching.go
+++ b/core/scripts/functions/src/fetching.go
@@ -11,6 +11,7 @@ import (
 	"github.com/urfave/cli"
 
 	helpers "github.com/smartcontractkit/chainlink/core/scripts/common"
+	ubig "github.com/smartcontractkit/chainlink/v2/core/chains/evm/utils/big"
 	"github.com/smartcontractkit/chainlink/v2/core/web/presenters"
 )