Add rpc newHeads method

Author: DylanTinianov

common/client/multi_node.go

@@ -172,7 +172,6 @@ func (c *MultiNode[CHAIN_ID, RPC_CLIENT]) HighestChainInfo() ChainInfo {
 // Nodes handle their own redialing and runloops, so this function does not
 // return any error if the nodes aren't available
 func (c *MultiNode[CHAIN_ID, RPC_CLIENT]) Dial(ctx context.Context) error {
-	fmt.Println("MULTINODE DIAL")
 	ctx = context.Background() // TODO: remove this line
 	return c.StartOnce("MultiNode", func() (merr error) {
 		if len(c.primaryNodes) == 0 {

common/client/node.go

@@ -244,7 +244,6 @@ func (n *node[CHAIN_ID, HEAD, RPC_CLIENT]) Start(startCtx context.Context) error
 // Node lifecycle is synchronous: only one goroutine should be running at a
 // time.
 func (n *node[CHAIN_ID, HEAD, RPC_CLIENT]) start(startCtx context.Context) {
-	fmt.Println("NODE START")
 	startCtx = context.Background() // TODO: remove this line
 	if n.state != NodeStateUndialed {
 		panic(fmt.Sprintf("cannot dial node with state %v", n.state))

common/client/node_lifecycle.go

@@ -74,8 +74,6 @@ const (
 	msgDegradedState = "Chainlink is now operating in a degraded state and urgent action is required to resolve the issue"
 )
 
-// const rpcSubscriptionMethodNewHeads = "newHeads"
-
 // Node is a FSM
 // Each state has a loop that goes with it, which monitors the node and moves it into another state as necessary.
 // Only one loop must run at a time.

core/chains/evm/client/chain_client.go

@@ -2,7 +2,6 @@ package client
 
 import (
 	"context"
-	"fmt"
 	"math/big"
 	"sync"
 	"time"
@@ -259,7 +258,6 @@ func (c *chainClient) ConfiguredChainID() *big.Int {
 }
 
 func (c *chainClient) Dial(ctx context.Context) error {
-	fmt.Println("CHAINCLIENT DIAL") // TODO: REMOVE
 	return c.multiNode.Dial(ctx)
 }
 

core/chains/evm/client/chain_client_test.go

@@ -704,6 +704,7 @@ func (x *sendTxService) SendRawTransaction(ctx context.Context, signRawTx hexuti
 	x.sentCount.Add(1)
 	return nil
 }
+*/
 
 func TestEthClient_SubscribeNewHead(t *testing.T) {
 	t.Parallel()
@@ -727,10 +728,12 @@ func TestEthClient_SubscribeNewHead(t *testing.T) {
 
 	ethClient := mustNewChainClientWithChainID(t, wsURL, chainId)
 	err := ethClient.Dial(tests.Context(t))
+	fmt.Println("DIALLED!!")
 	require.NoError(t, err)
 
 	headCh, sub, err := ethClient.SubscribeNewHead(ctx)
 	require.NoError(t, err)
+	fmt.Println("SUBSCRIBED!!")
 
 	select {
 	case err := <-sub.Err():
@@ -743,7 +746,6 @@ func TestEthClient_SubscribeNewHead(t *testing.T) {
 	}
 	sub.Unsubscribe()
 }
-*/
 
 func newMockRpc(t *testing.T) *client.MockChainClientRPC {
 	mockRpc := client.NewMockChainClientRPC(t)

core/chains/evm/client/rpc_client.go

@@ -117,6 +117,8 @@ var (
 	}, []string{"evmChainID", "nodeName", "rpcHost", "isSendOnly", "success", "rpcCallName"})
 )
 
+const rpcSubscriptionMethodNewHeads = "newHeads"
+
 // RPCClient includes all the necessary generalized RPC methods along with any additional chain-specific methods.
 //
 //go:generate mockery --quiet --name RPCClient --output ./mocks --case=underscore
@@ -215,7 +217,7 @@ func NewRPCClient(
 
 func (r *RpcClient) SubscribeToHeads(ctx context.Context) (<-chan *evmtypes.Head, commontypes.Subscription, error) {
 	channel := make(chan *evmtypes.Head)
-	sub, err := r.subscribe(ctx, channel)
+	sub, err := r.subscribe(ctx, channel, rpcSubscriptionMethodNewHeads)
 	return channel, sub, err
 }